feat: surface handler results to middleware chain#47
Merged
bougyman merged 1 commit intorubyists:mainfrom Apr 29, 2026
Merged
Conversation
bougyman
reviewed
Apr 28, 2026
| lambda do |wrapper| | ||
| result = execute_handler.call(wrapper, handler) | ||
| process_result(wrapper, result, callbacks) | ||
| result |
Member
There was a problem hiding this comment.
Why wouldn't #process_result just return a Result?
Contributor
Author
There was a problem hiding this comment.
i'm not sure i'm following. so we need to pass the result of actually executing the handler to the middleware chain. process_result just takes the result that is returned and calls the appropriate callback for the transport (req/reply or jetstream).
pmcclory-pp
force-pushed
the
surface-handler-results-to-middleware
branch
2 times, most recently
from
77aa415 to
df0aea6
Compare
pmcclory-pp
force-pushed
the
surface-handler-results-to-middleware
branch
from
df0aea6 to
ce5e055
Compare
bougyman
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use case is for OTEL tracing middleware. want to mark spans as errored if the handler failed. so errors can easily be identified, sampled etc