Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The updated pager module docstring is currently broken, and the new default runner can raise hard when sh isn’t available (e.g., on Windows targets) instead of gracefully falling back.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the CLI pager invocation so that pagers which render to standard output (rather than interacting via /dev/tty) work correctly in LinearCli.CLI.Pager.
Changes:
- Switch the default pager runner from
System.shell/1to aPort.open/2-based runner intended to inherit the terminal’s standard streams. - Add a test setup hook to ensure
$PAGERis consistently unset/restored across tests.
File summaries
| File | Description |
|---|---|
| app/lib/linear_cli/cli/pager.ex | Changes the default pager execution strategy and updates related module documentation. |
| app/test/linear_cli/cli/pager_test.exs | Adds setup to isolate $PAGER environment state during the pager test suite. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+89
to
+104
| # `System.shell/1` captures a child's stdout. That made pagers such as | ||
| # `bat` appear to succeed while their output was silently discarded. | ||
| defp run_pager(command) do | ||
| shell = System.find_executable("sh") || raise "could not find sh on PATH" | ||
|
|
||
| port = | ||
| Port.open({:spawn_executable, shell}, [ | ||
| :nouse_stdio, | ||
| :exit_status, | ||
| args: ["-c", command] | ||
| ]) | ||
|
|
||
| receive do | ||
| {^port, {:exit_status, status}} -> {"", status} | ||
| end | ||
| end |
Comment on lines
13
to
+16
| When paging is needed the content is written to a temp file and the | ||
| pager is invoked via `System.shell/1`, which — like | ||
| `Owl.IO.open_in_editor/2`'s own use of the same function — lets the | ||
| child process open `/dev/tty` directly for interactive keyboard | ||
| control. | ||
| The pager inherits the terminal's standard streams, so pagers that | ||
| render to standard output (such as `bat`) work as well as interactive | ||
| pagers such as `less`. |
This was referenced Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.