This repository was archived by the owner on Dec 4, 2023. It is now read-only.
Force compilers to use english#149
Merged
ignisf merged 1 commit intorubyjs:masterfrom Nov 16, 2014
Merged
Conversation
ignisf
added a commit
that referenced
this pull request
Nov 16, 2014
…english-locales Force compilers to use english
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compiling was failing with this:
when calling on
@compiler.targetbecause my gcc uses a spanish localization, soTARGET_REGEXPwasn't finding anything. This is a simple fix to force gcc to use an english locale.Sorry about the lack of tests, I couldn't figure out how to test this.
PS: While researching this issue I came across the -dumpmachine parameter, which exists in every supported gcc version (and in my machine also works with clang, but somehow I think it's using gcc internally). Maybe using that parameter in the future is more solid than regexing
-v.There is also a
-dumpversionparameter but it was giving me inconsistencies with clang:and