This repository was archived by the owner on Dec 4, 2023. It is now read-only.
Conversation
* for some reason, the git clean task inside the gyp directory was returning an exit status of `1'` even though it was cleaning out files. Just ignore the exit status * chomp the output of the `git-svn` invocation. At least on OSX, it was throwing a specious warning about "-f" not being a valid command, and if the force checkout was actually necessary, it was failing
Collaborator
|
I've entirely removed the checkout logic from trunk and thus removed the dependency on git-svn and svn... Have to do it here too sometime. Looks good for merging. |
Collaborator
Author
|
Alright, thanks for the heads up. One of the reason's I wanted to get our builds sorted is so that we can automatically build and store artifacts on all the different platforms so that we can really reduce the effort involved to generate a release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
returning an exit status of
1even though it was cleaning outfiles. Just ignore the exit status
git-svninvocation. At least on OSX, it wasthrowing a specious warning about "-f" not being a valid command, and
if the force checkout was actually necessary, it was failing