add a patch for clang 7.0#177
Conversation
|
Thank you sooooooooooo much for this. You're my hero. I built the therubyracer manually with your branch and it was successful. I'd previously been banging my head against the keyboard for about ten hours. Thank you, thank you, thank you. 👍 ❤️ 👍 ❤️ 👍 ❤️ 👍 ❤️ 👍 ❤️ 👍 ❤️ PS: I wasn't able to have it build just by adding your branch as the source in my Gemfile, because it seems like the Gyp / v8 vendor submodules weren't getting checked out, but that might be perfectly normal. I've never had to build a Gem before, perhaps in the actual distributed versions they usually distribute an already-checked-out vendor/** directory. Because of this I ended up cloning your fork and checking out your branch before manually running rake, after which everything went by swimmingly. THANK YOU. |
|
I wonder why the hell is this failing despite of https://github.com/cowboyd/libv8/blob/master/ext/libv8/builder.rb#L46 |
|
I'm exhausted. |
|
Great job! This fixes it. |
|
@ignisf is this good to go? |
|
👍 |
|
Thanks @semnil! |
|
What about update for 3.16... still cannot install it on 10.11 |
|
@Aeon the latest release for 3.16 should have this patch on it. Are you sure you're using |
|
@cowboyd I can confirm this patch is not in |
|
I just ran into this as well. |
|
+1 |
|
It finally worked for me once I cleared out my versions of v8 installed with brew and uninstalled all my previous libv8 gems |
|
When tried to install from master: |
libv8 fails to compile in El Capitan. This issue was resolved at rubyjs/libv8#177 and so this was easily fixed by updating libv8.
I can build for the time being with The Xcode 7.0 and the OS X El Capitan 10.11.