Fix typos, positive/negative statements, etc.#51
Merged
zverok merged 1 commit intorubyreferences:masterfrom Feb 11, 2023
keithrbennett:keithrbennett/3.2-fixes
Merged
Fix typos, positive/negative statements, etc.#51zverok merged 1 commit intorubyreferences:masterfrom keithrbennett:keithrbennett/3.2-fixes
zverok merged 1 commit intorubyreferences:masterfrom
keithrbennett:keithrbennett/3.2-fixes
Conversation
keithrbennett
commented
Feb 10, 2023
| t.dup.tag #=> nil | ||
| ``` | ||
| This is a [bug](https://bugs.ruby-lang.org/issues/19362) and will probably [change](https://github.com/ruby/ruby/pull/7178) in Ruby 3.2.1. | ||
| This is a [bug](https://bugs.ruby-lang.org/issues/19362) and will probably [change](https://github.com/ruby/ruby/pull/7178) in Ruby 3.2.2. |
Contributor
Author
There was a problem hiding this comment.
I checked and this fix doesn't seem to be in 3.2.1 so I bumped the version.
Contributor
|
@keithrbennett Thanks a lot! Both my English skills and my attention to typos aren't in the best shape (now and always) 😁 |
Contributor
Author
|
No problem, you did the hard part! I'm very happy to help. Thanks again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, @zverok , thank you so much for this document! I'm sure it takes a lot of time and effort to take this on, and I appreciate it.
I found various issues that I attempted to correct here. Some were typos, others were wording improvements, but some also changed the meaning of the text to what I think you intended.
I hope this is helpful.