Add CVE-2018-1000211 for Doorkeeper#343
Merged
phillmv merged 1 commit intorubysec:masterfrom Jul 18, 2018
Merged
Conversation
Member
|
Dope, thanks. @f3ndot how serious would say this vuln is? |
Contributor
Author
|
@phillmv I think it's debatable/matter of perspective on the severity of this vuln. I liken it to the logout button not working on a website, so that's pretty severe in terms of things not working as expected. However, in order to take advantage, the access and/or refresh tokens must be compromised-- an already difficult feat. Ignoring the ease of which an attacker can get into the appropriate pre-conditions to leverage the attack, it's medium/high because the entire feature is, in fact, non-functional for all public apps. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge pending the release of 5.0.0.rc2 and 4.4.0: doorkeeper-gem/doorkeeper#1120 (comment)they are now released