Skip to content

Fix patched version for nokogiri (GHSA-2qc6-mcvw-92cw)#519

Merged
reedloden merged 1 commit intorubysec:masterfrom
GUI:GHSA-2qc6-mcvw-92cw
Oct 18, 2022
Merged

Fix patched version for nokogiri (GHSA-2qc6-mcvw-92cw)#519
reedloden merged 1 commit intorubysec:masterfrom
GUI:GHSA-2qc6-mcvw-92cw

Conversation

@GUI
Copy link
Copy Markdown
Contributor

@GUI GUI commented Oct 18, 2022

GHSA-2qc6-mcvw-92cw is reported to be fixed by 1.13.9+, not 1.13.19.

GHSA-2qc6-mcvw-92cw is reported to be fixed by 1.13.9+, not 1.13.19.
@alder-a
Copy link
Copy Markdown

alder-a commented Oct 18, 2022

Please merge this, as it is breaking our audit step in our build

@aldent95
Copy link
Copy Markdown

Can this please be merged soon? I'm sure we are not the only ones having issues with their CI/CD yelling at them about failing bundle audits because of this issue.

@GSmes
Copy link
Copy Markdown

GSmes commented Oct 18, 2022

Merge, please! 🙏🏻 Let this be a lesson in why you don't release shit immediately before signing off for the day 🤣

@carlwiedemann
Copy link
Copy Markdown

cc @reedloden @postmodern This is blocking CI for lots of people, it should be a trivial review/merge.

@JuanitoFatas
Copy link
Copy Markdown

Fyi: We could ignore this CVE to unblock CI until this gets merged

bundle-audit check --ignore GHSA-2qc6-mcvw-92cw

@aldent95
Copy link
Copy Markdown

Fyi: We could ignore this CVE to unblock CI until this gets merged

bundle-audit check --ignore GHSA-2qc6-mcvw-92cw

We have tried that. Not sure if it's an issue with our build system but it's not working.

@rsanheim
Copy link
Copy Markdown

Fyi: We could ignore this CVE to unblock CI until this gets merged

This worked for us on circleci FWIW:

bundle exec bundle-audit update && bundle exec bundle-audit check --ignore GHSA-2qc6-mcvw-92cw

@reedloden reedloden merged commit 137a425 into rubysec:master Oct 18, 2022
@royalpeasantry
Copy link
Copy Markdown

Fyi: We could ignore this CVE to unblock CI until this gets merged

bundle-audit check --ignore GHSA-2qc6-mcvw-92cw

We have tried that. Not sure if it's an issue with our build system but it's not working.

It also did not work for me until I updated the bundler-audit gem

bin/bundle update bundler-audit
...
Fetching bundler-audit 0.9.1 (was 0.6.1)
Installing bundler-audit 0.9.1 (was 0.6.1)
...

@reedloden
Copy link
Copy Markdown
Member

Apologies to all for my typo! Sorry to any extra work this may have caused folks.

@reedloden reedloden linked an issue Oct 18, 2022 that may be closed by this pull request
@flavorjones
Copy link
Copy Markdown
Contributor

@reedloden Would it be helpful in the future if I shipped a PR here for the inevitable next nokogiri/libxml2 GHSA? Happy to do it, I've got a release checklist.

@radar
Copy link
Copy Markdown
Contributor

radar commented Oct 19, 2022

@reedloden It's okay :) We all make mistakes. Thank you for your diligence on maintaining this repo.

@reedloden
Copy link
Copy Markdown
Member

@reedloden Would it be helpful in the future if I shipped a PR here for the inevitable next nokogiri/libxml2 GHSA? Happy to do it, I've got a release checklist.

Yes, please. That would be amazing!

@postmodern
Copy link
Copy Markdown
Member

I bet we could add additional linter tests to check that every >= or ~> version actually exists on rubygems.org.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nokogiri GHSA-2qc6-mcvw-92cw requires invalid version