Added :encrypter option to Zip::File#initialize to make it easier to create encrypted zip files
#267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 6, 2016 18:12
… create new encrypted zip files with Zip::File.open
|
Why was this PR not merged? |
Member
|
Not sure really; it came in before my time as maintainer. It does seem a sensible change, but the methods have changed quite a bit since then, so I'll have to implement this differently now. I'll raise an issue to remind me. |
|
@hainesr I'd close this one, and if anyone wants to provide an updated PR, then maybe consider it. But in general, encrypted Zip files are rarely used. So I'm not convinced it's worth the added work and maintenance cost. |
Member
|
As noted, this PR will no longer merge and will need to be done in a different way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it easier to create encrypted zipfiles