Fix depreciation warning: abstract_output_stream_test.rb:60: warning: `$,' is deprecated #467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in https://bugs.ruby-lang.org/issues/14240 and implemented in ruby/ruby@6298ec2 setting OUTPUT_FIELD_SEPERATOR to a non-nil value is now depricated.
Since modifying OUTPUT_FIELD_SEPARATOR is deprecated, there's no need for us to do this in our test.
Since we are using the default behavior of OUTPUT_FIELD_SEPERATOR anyway, let's allow Ruby to maange that default for us, so if it should change in the future, we don't have to change.
hainesr
requested changes
May 31, 2021
Member
|
Thanks for the PR @bbuchalter - all merged in now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello rubyzip community! 👋
I was thinking about making a small contribution in another area, so I went to run the test suite and noticed this deprecation warning:
abstract_output_stream_test.rb:60: warning: '$,' is deprecated.I learned that setting
$,(aka$OUTPUT_FIELD_SEPERATOR) to a non-nil value is now deprecated. This was discussed in https://bugs.ruby-lang.org/issues/14240 and implemented in ruby/ruby@6298ec2.As a result, I've modified both some test code and application code to assume a world in which this value is always
nil.Since I'm new to this community, and this code was originally almost 20 years ago(!), perhaps we should leave it as is until forced to do otherwise?
Anyway, just a little contribution that I hope is found helpful. Let me know if a CHANGELOG entry would be expected for a change this small.