use sb-md5 if on sbcl, otherwise improve error if missing md5sum#10
Merged
rudolfochrist merged 3 commits intorudolfochrist:masterfrom Feb 12, 2024
Merged
use sb-md5 if on sbcl, otherwise improve error if missing md5sum#10rudolfochrist merged 3 commits intorudolfochrist:masterfrom
rudolfochrist merged 3 commits intorudolfochrist:masterfrom
Conversation
rudolfochrist
approved these changes
Feb 12, 2024
Owner
rudolfochrist
left a comment
There was a problem hiding this comment.
Great. Thank you for looking into this. Maybe we should add md5sum to the PREREQUISITES section in the README.
Collaborator
Author
|
It looks like we can use openssl: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently it is computing md5sum by running the cli program with uiop:
Unfortunately in shells without
pipefailset, if cut is present but md5sum is missing this will not return a bad error status, so uiop won't signal an error, leading to a md5-mismatch error later without a clear reason why, as in #8This changes it to use
sb-md5if we are on sbcl, and if not on sbcl then still shell out to md5sum, but without piping to cut so that uiop will signal a clear error:Couldn't execute "md5sum": No such file or directory