Fix corner cases in AVM2 class singletons #7790
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our AVM2 implementation currently contains a failsafe for class coercion intended to support writing self-referencing static properties (singletons) in class initializers. However, it does not account for AVM2 properties being nullable, and will spuriously error with
Attempted to perform (private) resolution of nonexistent type (type)when coercingnullorundefined.This adds a check for those two values and a test to verify them. As far as I'm aware, we will not need similar failsafes for other primitive values as our AS3 implementations of such do not have self-referencing static properties.
The code pattern this is intended to support is: