Fix Type::getMapping from aliased index#591
Merged
Merged
Conversation
Contributor
Author
|
Removed fa5612a as it was based on a misunderstanding of how Elastica handles types and mappings. The specified issue should be resolved and tests should now pass. 😀 |
Contributor
Author
|
I'm not sure why only some of those tests erred, is there a way to rerun them? |
ruflin
added a commit
that referenced
this pull request
Apr 21, 2014
Fix Type::getMapping from aliased index
Owner
|
I don't know why Travis is doing this some times. I didn't happen now for quite some time and now seems to be an issue again. I merged it anyways. Lets see how the next build is doing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #588.
That 3rd commit is likely a breaking change. Not sure what the policy on those is, I'll leave it's inclusion to your discretion. (EDIT: see comments)