Don't attempt to hide colour picker if it's not visible #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Thanks for your quick reply. That seems to work great! The colour picker still disappears when clicking off it, and the digest cycle no longer triggers on every mouse click. If you're happy with the change, should I run a |
Owner
|
That would be great. Follow the release file if you haven't already found it. Make it v0.8.2. Could you also run Thanks 👍 |
Contributor
Author
|
Done. Let me know if I've missed anything! |
ruhley
added a commit
that referenced
this pull request
Jan 29, 2016
Don't attempt to hide colour picker if it's not visible
Owner
|
Merged and released in v0.8.2. Thanks for the pull request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I have some complicated pages with colour pickers on them, and whenever the user clicks anywhere on the page it triggers a digest cycle. This is a bit of a problem when combined with numeric inputs or other elements on the page which get clicked a lot :) I'm assuming this is necessary to ensure the colour picker hides though, so I was wondering if it would be possible to only trigger the cycle if the colour picker is already showing.
Thanks for your help :)