Make bootstrap variables changeable simply #8

Open
azr opened this Issue Feb 22, 2012 · 14 comments

Comments

Projects
None yet
4 participants
@ruian

This comment has been minimized.

Show comment Hide comment
@ruian

ruian Feb 22, 2012

Owner

I will add this when i will have some time ;-)

Owner

ruian commented Feb 22, 2012

I will add this when i will have some time ;-)

@andrewtch andrewtch referenced this issue Feb 23, 2012

Merged

Copy images #9

@andrewtch

This comment has been minimized.

Show comment Hide comment
@andrewtch

andrewtch Feb 23, 2012

Contributor

@ruian , any ideas how to implement it, or where to make 'modifications'? (config.yml, or as an argument to a console?)

maybe it would be better just implement --append-less switch to :compile?

Contributor

andrewtch commented Feb 23, 2012

@ruian , any ideas how to implement it, or where to make 'modifications'? (config.yml, or as an argument to a console?)

maybe it would be better just implement --append-less switch to :compile?

@ruian

This comment has been minimized.

Show comment Hide comment
@ruian

ruian Feb 24, 2012

Owner

I don't know if it's a good idea to put less variables into config.yml.
I think it's better to a variables.less reference into the user bundle.
And use it instead of default twitter\bootstrap\v2\less\variables.less

Owner

ruian commented Feb 24, 2012

I don't know if it's a good idea to put less variables into config.yml.
I think it's better to a variables.less reference into the user bundle.
And use it instead of default twitter\bootstrap\v2\less\variables.less

@andrewtch

This comment has been minimized.

Show comment Hide comment
@andrewtch

andrewtch Feb 26, 2012

Contributor

Forcing users to copy whole variables.less is a pain.

what about twitter:bootstrap:compile v2 --apend-less MyCoolBundle:lessvars.less
(which just adds src\MyCoolBundle\Resources\less\lessvars.less to variables before compilation?)

Contributor

andrewtch commented Feb 26, 2012

Forcing users to copy whole variables.less is a pain.

what about twitter:bootstrap:compile v2 --apend-less MyCoolBundle:lessvars.less
(which just adds src\MyCoolBundle\Resources\less\lessvars.less to variables before compilation?)

@ruian

This comment has been minimized.

Show comment Hide comment
@ruian

ruian Feb 26, 2012

Owner

Yes it could be a solution

Owner

ruian commented Feb 26, 2012

Yes it could be a solution

@azr

This comment has been minimized.

Show comment Hide comment
@azr

azr Feb 27, 2012

Yes and you could mix the two solution, if there is no --apend-less you could just check in the configurations.

And that would make the Bundle and cool less compiler :p

edit : It would be great too to be able to set se default boostrap version in the configuration file too

azr commented Feb 27, 2012

Yes and you could mix the two solution, if there is no --apend-less you could just check in the configurations.

And that would make the Bundle and cool less compiler :p

edit : It would be great too to be able to set se default boostrap version in the configuration file too

@andrewtch

This comment has been minimized.

Show comment Hide comment
@andrewtch

andrewtch Feb 27, 2012

Contributor

like:

ruian_bootstrap:
  lessvars: |
    @boo: 123
    @foo: 456

?

Contributor

andrewtch commented Feb 27, 2012

like:

ruian_bootstrap:
  lessvars: |
    @boo: 123
    @foo: 456

?

@azr

This comment has been minimized.

Show comment Hide comment
@azr

azr Feb 28, 2012

Something more like :

ruian_bootstrap:
 twitter_bootstrap_version: V2
 lessfile: ../src/Acme/Bundle/Resource/Public/less/file.less 
  #or
 lessdir: ../src/Acme/Bundle/Resource/Public/less/my_awesome_stylesheet/

Not sure if lessing a whole directory is possible though ?

azr commented Feb 28, 2012

Something more like :

ruian_bootstrap:
 twitter_bootstrap_version: V2
 lessfile: ../src/Acme/Bundle/Resource/Public/less/file.less 
  #or
 lessdir: ../src/Acme/Bundle/Resource/Public/less/my_awesome_stylesheet/

Not sure if lessing a whole directory is possible though ?

@ruian

This comment has been minimized.

Show comment Hide comment
@ruian

ruian Feb 28, 2012

Owner

With your way using shortcuts will be easier

AcmeBundle:file.less instead of ../src/Acme/Bundle/Resource/Public/less/file.less

But important i think this addon is just for manipulating bootstrap's variables. not to includes yours into bootstrap.

Owner

ruian commented Feb 28, 2012

With your way using shortcuts will be easier

AcmeBundle:file.less instead of ../src/Acme/Bundle/Resource/Public/less/file.less

But important i think this addon is just for manipulating bootstrap's variables. not to includes yours into bootstrap.

@andrewtch

This comment has been minimized.

Show comment Hide comment
@andrewtch

andrewtch Feb 28, 2012

Contributor

Indeed. Manipulating whole boostrap would add more problems like 'append or prepend user files?' 'where to append user files, in bootsrap.less or variables.less'?

Contributor

andrewtch commented Feb 28, 2012

Indeed. Manipulating whole boostrap would add more problems like 'append or prepend user files?' 'where to append user files, in bootsrap.less or variables.less'?

@azr

This comment has been minimized.

Show comment Hide comment
@azr

azr Feb 29, 2012

Yes I think you're right, it would be difficult to know what to do with everything.
And in fact I was more thinking about adding completely different less projects to be compiled in a different css file

ruian_bootstrap:
 ...
 less_projetcs:
  my_acme_project:
   dir: AcmeBundle:dir.less
   params: ~
   ...

But may be that's not the same project and certainly not the right issue

azr commented Feb 29, 2012

Yes I think you're right, it would be difficult to know what to do with everything.
And in fact I was more thinking about adding completely different less projects to be compiled in a different css file

ruian_bootstrap:
 ...
 less_projetcs:
  my_acme_project:
   dir: AcmeBundle:dir.less
   params: ~
   ...

But may be that's not the same project and certainly not the right issue

@andrewtch

This comment has been minimized.

Show comment Hide comment
@andrewtch

andrewtch Feb 29, 2012

Contributor

Well, then you should need lesscompiler bundle instead of bootstrap bundle )

Contributor

andrewtch commented Feb 29, 2012

Well, then you should need lesscompiler bundle instead of bootstrap bundle )

@ruian

This comment has been minimized.

Show comment Hide comment
@ruian

ruian Feb 29, 2012

Owner

Yep @andrewtch i agree

Owner

ruian commented Feb 29, 2012

Yep @andrewtch i agree

@Blackskyliner

This comment has been minimized.

Show comment Hide comment
@Blackskyliner

Blackskyliner Dec 14, 2012

It seems this Issue was resolved (in terms of this 'bundle should not do this')

#closerequest

It seems this Issue was resolved (in terms of this 'bundle should not do this')

#closerequest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment