Added 6px font for enumeration#16
Merged
rumkit merged 4 commits intorumkit:masterfrom Aug 30, 2018
Merged
Conversation
changed font file build action to embedded resource
rumkit
requested changes
Aug 29, 2018
Owner
rumkit
left a comment
rumkit
left a comment
There was a problem hiding this comment.
I suggest to use embedded resource instead of resource resx designer. Looks simpler but on the other hand there is no code completion for resource names
rumkit
reviewed
Aug 29, 2018
| /// </summary> | ||
| /// <param name="resourceName">name of resource, containing font</param> | ||
| /// <param name="size">font size</param> | ||
| private Font GetCustomFont(string resourceName, float size) |
Owner
There was a problem hiding this comment.
possibly a parameter with resource name can make it better
rumkit
reviewed
Aug 29, 2018
| <?xml version="1.0" encoding="utf-8"?> | ||
| <packages> | ||
| <package id="CommandLineParser" version="1.9.71" targetFramework="net46" /> | ||
| <package id="Microsoft.Net.Compilers" version="2.9.0" targetFramework="net46" developmentDependency="true" /> |
Owner
There was a problem hiding this comment.
for some reason this causes merge conflict, probably we can include this in master branch, so all people with older VS can build the solution with less issues
Collaborator
Author
|
Okay. I'm not sure what to do now since you've already fixed it. |
rumkit
approved these changes
Aug 30, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This font should look readable on very los-res .png files with patterns and on big ones. I removed top padding since it caused numbers to "leak" from their cells.
Please look at the code carefully, it was stackoverflow-driven developed 💀