Skip to content

Conversation

@masci
Copy link
Contributor

@masci masci commented Apr 2, 2025

Description

TODO (attempting at a non-breaking fix)

Fixes #18337

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.

  • I added new unit tests to cover this change
  • I believe this change is already covered by existing unit tests

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

@masci masci changed the title fix: isolate event buffers for to avoid interferences between different steps fix: isolate event buffers to avoid interferences between steps Apr 3, 2025
@masci masci marked this pull request as ready for review April 4, 2025 10:32
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Apr 4, 2025
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Apr 8, 2025
@logan-markewich logan-markewich merged commit 27fca84 into main Apr 8, 2025
10 of 11 checks passed
@logan-markewich logan-markewich deleted the massi/collect_events branch April 8, 2025 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Naming of @steps in a Workflow affect whether the execution will halt

3 participants