Fix asyncio dep in tests #18367
Merged
Fix asyncio dep in tests #18367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
dosubot
bot
added
size:L
Collaborator
Author
|
Hmm, something is broken for python 3.9, will need to investigate |
Collaborator
Author
|
Ok, python3.9 does not like some of the ways our tests were working with async Disabling some problematic tests for python3.9. While this is not ideal, workflows generally work with python3.9 (and this version of python is being deprecated later this year anyways) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As flagged by Adrian here, pytest_asyncio is an implicit dependency
AFAIK there was not an easy way to force pants to install this for every package that needs it besides importing it, so I scripted a change to add the imports needed.
Now, async tests will properly run in pants