Skip to content

Conversation

@jaelgu
Copy link
Contributor

@jaelgu jaelgu commented Apr 7, 2025

Description

Fix doc build issue to show MilvusAsyncAPIDemo notebook in side menu.

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

How Has This Been Tested?

Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.

  • I believe this change is already covered by existing unit tests

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I ran make format; make lint to appease the lint gods

Signed-off-by: Mengjia Gu <mengjia.gu@zilliz.com>
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Apr 7, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 7, 2025
@logan-markewich
Copy link
Collaborator

Fyi normally when I do a "stable" release on the repo, I run a script that auto-populates this. But totally fine to manually add it too

@logan-markewich logan-markewich merged commit b1ebcb7 into run-llama:main Apr 7, 2025
11 checks passed
@jaelgu jaelgu deleted the mg-milvus-docs branch April 8, 2025 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants