Skip to content

Conversation

@rrozanski-smabbler
Copy link
Contributor

Description

It's just a link fix in README - without https:// github was doing some weird things with the link.

Fixes # (issue)

New Package?

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

  • Yes
  • [x ] No

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • [x ] No

Type of Change

Please delete options that are not relevant.

How Has This Been Tested?

Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.

  • I added new unit tests to cover this change
  • [x ] I believe this change is already covered by existing unit tests

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

trying to fix random 403 errors when opening links
removing target="_blank", it's unsupported by github .md
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Apr 9, 2025
fixing example: API url shouldn't have https://, because  python's http module throws an exception
fixing example in docstring - python's https library throws exception when provided with API url starting with https://
@rrozanski-smabbler
Copy link
Contributor Author

To summarize these additional commits: I've added fixes to urls in examples, in README and docstring. The code itself is not affected

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 9, 2025
@logan-markewich logan-markewich merged commit c88cbdf into run-llama:main Apr 9, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants