edits #208
edits #208
Conversation
adrianlyjak
force-pushed
the
adrian/changesets-attempt
branch
from
4a6f27c to
c9e6475
Compare
adrianlyjak
force-pushed
the
adrian/changesets-attempt
branch
from
c9e6475 to
70eeb20
Compare
AstraBert
left a comment
AstraBert
left a comment
There was a problem hiding this comment.
lgtm, this is way cleaner :))
| "name": "llama-index-utils-workflow", | ||
| "version": "0.5.0", | ||
| "private": "true", | ||
| "private": "false", |
There was a problem hiding this comment.
I don't know if public or private makes a big difference here, since we don't publish this as a JS package nevertheless, but the ratio behind setting it as private is because this is not a JS package and should not be interpreted as such by changesets
There was a problem hiding this comment.
The release process is completely run by our script, so this doesn't get published.
Maybe silly, but I'm reading the package.json private value in changesets.py to infer whether the package should be published (Could instead just treat all folders with both pyproject.toml and package.json as ones that should be published)
There was a problem hiding this comment.
Oh yeah, makes sense then, fine to keep it as public :))
No description provided.