Skip to content

Revert "Sawra/runagent cloud support"#70

Merged
sawradip merged 1 commit into
mainfrom
revert-69-sawra/runagent_cloud_support
Sep 25, 2025
Merged

Revert "Sawra/runagent cloud support"#70
sawradip merged 1 commit into
mainfrom
revert-69-sawra/runagent_cloud_support

Conversation

@sawradip
Copy link
Copy Markdown
Contributor

@sawradip sawradip commented Sep 25, 2025

Reverts #69

Summary by CodeRabbit

  • New Features

    • Added CLI commands: version, deploy_local, deploy, upload, db logs, and db cleanup.
    • Interactive init with explicit framework flags and clearer summaries.
  • Enhancements

    • Richer CLI output, tables, and consistent error messages.
    • Framework handling now string-based with auto-detect on upload; SDK exposes detect_framework.
    • More reliable remote deployment and status checks; simplified template connectivity.
  • Bug Fixes

    • Sync is safely disabled without authentication; steadier streaming error handling.
  • Chores

    • Version aligned to 0.1.20 across packages.
    • Added Rust dependency update.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Sep 25, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This PR rolls back versions to 0.1.20 across modules, replaces the Framework enum with string-based handling, expands CLI commands (version, deploy, deploy_local, upload, logs), refactors SDK client/deployment flows (framework metadata, detection), adjusts server/local sync behavior, simplifies DB schema, updates template connectivity, and streamlines release scripting.

Changes

Cohort / File(s) Summary
Version rollback and metadata
CHANGELOG.md, pyproject.toml, runagent-go/runagent/version.go, runagent-rust/runagent/Cargo.toml, runagent-ts/package.json, runagent/__init__.py, runagent/__version__.py
Roll back versions to 0.1.20; adjust changelog sections; align tool configs (mypy/ruff); update language-specific version constants.
CLI surface and commands
runagent/cli/commands.py, runagent/cli/main.py, runagent/cli/utils.py
Add version option/command; add deploy, deploy_local, upload, logs, cleanup_logs; move from enum-based to explicit framework flags; remove framework option utilities and single-selection helper.
Framework enum removal → string framework
runagent/utils/enums/framework.py (deleted), runagent/utils/enums.py (new), runagent/utils/agent.py, runagent/sdk/server/framework/__init__.py, runagent/utils/schema.py
Delete Framework enum; introduce new enums (ResponseStatus, PythonicType, WebhookType) and FrameworkType alias; return framework as string from detection; switch executor dispatch and schema to string/union-based.
SDK client and deployment flow
runagent/sdk/rest_client.py, runagent/sdk/deployment/remote.py, runagent/sdk/sdk.py, runagent/sdk/deployment/middleware_sync.py
Rebuild RestClient with structured init, validation, upload/deploy helpers, and diagnostics; add framework metadata and auto-detection to uploads; expose detect_framework in SDK; add explicit sync enable flags and safer checks in middleware sync.
Server/local runtime adjustments
runagent/sdk/server/local_server.py, runagent/sdk/server/socket_utils.py
Send framework as raw string (not enum.value); generate agent_id with UUID directly; remove env-guarded re-raise in streaming errors.
DB and template handling
runagent/sdk/db.py, runagent/sdk/template_manager.py
Remove fingerprint/is_local usage and comment out remote-agent methods; simplify agent getters; replace git subprocess connectivity check with list-based check; broaden exception handling.
Utility removal
runagent/utils/agent_id.py
Remove agent ID/fingerprint/metadata utilities and related helpers.
Release flow
release.sh
Reorder changelog generation post-tag handling; simplify messages; remove verbose summary steps; consolidate outputs.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor U as User
  participant CLI as runagent CLI
  participant SDK as RunAgentSDK
  participant RD as RemoteDeployment
  participant RC as RestClient
  participant MW as Middleware

  U->>CLI: runagent deploy --folder ./agent --framework ag2
  CLI->>SDK: upload_agent(folder, framework="ag2")
  SDK->>RD: upload_agent(folder_path, framework="ag2")
  alt framework provided
    RD->>RC: deploy_agent(folder_path, metadata={framework:"ag2"})
  else no framework
    RD->>RD: detect framework from folder
    RD->>RC: deploy_agent(folder_path, metadata={framework:detected})
  end
  RC->>RC: create zip, upload metadata + zip
  RC->>MW: POST /agents (metadata + artifact)
  MW-->>RC: {agent_id, status}
  RC-->>RD: deployment result
  RD-->>SDK: result
  SDK-->>CLI: result
  CLI-->>U: Print agent_id/status
Loading
sequenceDiagram
  autonumber
  participant LS as LocalServer
  participant MS as MiddlewareSyncService
  participant RC as RestClient

  LS->>MS: initialize()
  alt API key missing or error
    MS->>MS: set sync_enabled=false, enabled=false
  else valid key
    MS->>RC: validate_api_connection()
    RC-->>MS: health/auth status
    alt validation fails
      MS->>MS: set sync_enabled=false, enabled=false
    else success
      MS->>MS: set sync_enabled=true, enabled=true
    end
  end
  note over MS: All error paths explicitly disable syncing
Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~75 minutes

Possibly related PRs

Poem

A bunny bumps versions, hops back two,
Strings for frameworks—farewell enum crew.
Pack, zip, deploy, with metadata bright,
Local or remote, we launch into night.
Logs nibble neatly, sync flags behave—
Carrots for CI, and a tag to save. 🥕🐇

✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch revert-69-sawra/runagent_cloud_support

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4d93780 and a4f7b0e.

⛔ Files ignored due to path filters (1)
  • runagent-ts/package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (25)
  • CHANGELOG.md (1 hunks)
  • pyproject.toml (3 hunks)
  • release.sh (2 hunks)
  • runagent-go/runagent/version.go (1 hunks)
  • runagent-rust/runagent/Cargo.toml (1 hunks)
  • runagent-ts/package.json (1 hunks)
  • runagent/__init__.py (1 hunks)
  • runagent/__version__.py (1 hunks)
  • runagent/cli/commands.py (6 hunks)
  • runagent/cli/main.py (1 hunks)
  • runagent/cli/utils.py (0 hunks)
  • runagent/sdk/db.py (2 hunks)
  • runagent/sdk/deployment/middleware_sync.py (3 hunks)
  • runagent/sdk/deployment/remote.py (2 hunks)
  • runagent/sdk/rest_client.py (7 hunks)
  • runagent/sdk/sdk.py (3 hunks)
  • runagent/sdk/server/framework/__init__.py (1 hunks)
  • runagent/sdk/server/local_server.py (6 hunks)
  • runagent/sdk/server/socket_utils.py (0 hunks)
  • runagent/sdk/template_manager.py (1 hunks)
  • runagent/utils/agent.py (5 hunks)
  • runagent/utils/agent_id.py (0 hunks)
  • runagent/utils/enums.py (1 hunks)
  • runagent/utils/enums/framework.py (0 hunks)
  • runagent/utils/schema.py (2 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sawradip sawradip merged commit 7142276 into main Sep 25, 2025
1 of 2 checks passed
@coderabbitai coderabbitai Bot mentioned this pull request Oct 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant