Skip to content

Sawra/sdk fix ts#89

Merged
sawradip merged 2 commits into
mainfrom
sawra/sdk_fix_ts
Nov 13, 2025
Merged

Sawra/sdk fix ts#89
sawradip merged 2 commits into
mainfrom
sawra/sdk_fix_ts

Conversation

@sawradip
Copy link
Copy Markdown
Contributor

@sawradip sawradip commented Nov 13, 2025

Summary by CodeRabbit

  • Chores
    • Released version 0.1.29 with updates across all platform SDKs (Python, Go, Rust, TypeScript)
    • Enhanced release workflow security by transitioning to modern authentication standards
    • Implemented comprehensive type-checking standards to improve code reliability and consistency

- Added step to remove injected npm auth token after publishing.
- Cleared NODE_AUTH_TOKEN environment variable to prevent token leakage.
- Updated all SDK versions to 0.1.29
- Generated changelog with git-cliff
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Nov 13, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The PR bumps the project version from 0.1.28 to 0.1.29 across all SDK implementations (Python, Go, Rust, TypeScript), updates the TypeScript release workflow to use OIDC-based authentication, enhances mypy type-checking strictness, and updates the changelog.

Changes

Cohort / File(s) Summary
GitHub Actions & Release Workflow
\.github/workflows/typescript-release\.yml
Removes injected npm auth token step and sets empty NODE_AUTH_TOKEN environment variable to align with OIDC-based publishing instead of legacy token authentication.
Version Bumps
pyproject\.toml, runagent/__init__\.py, runagent/__version__\.py, runagent-go/runagent/version\.go, runagent-rust/runagent/Cargo\.toml, runagent-ts/package\.json
Bumps version constant/field from 0.1.28 to 0.1.29 across all SDK language implementations.
Type Checking Configuration
pyproject\.toml
Adds stricter mypy flags including disallow_untyped_defs, disallow_incomplete_defs, check_untyped_defs, disallow_untyped_decorators, no_implicit_optional, warn_redundant_casts, warn_unused_ignores, warn_no_return, and warn_unreachable.
Documentation
CHANGELOG\.md
Updates changelog heading to 0.1.28 and replaces entries to document GitHub Actions permissions update and version bump to 0.1.28.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

  • The changes consist primarily of repetitive version string updates across multiple files—low complexity per file but distributed across 6 version-related files.
  • GitHub Actions workflow modification is straightforward (adding one step and modifying environment variables).
  • Mypy configuration additions are standard type-checking flags with no behavioral impact.
  • Areas needing attention: Verify that the OIDC-based authentication setup in the workflow is correctly configured and that all version strings match across files.

Possibly related PRs

Poem

🐰 A hop, a bump, a version rise,
From 0.1.28 to 0.1.29!
OIDC tokens gleam so bright,
Mypy types all strictly right,
Release flows now verified and tight! ✨

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch sawra/sdk_fix_ts

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0aa0952 and c635e60.

⛔ Files ignored due to path filters (1)
  • runagent-ts/package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (8)
  • .github/workflows/typescript-release.yml (1 hunks)
  • CHANGELOG.md (1 hunks)
  • pyproject.toml (3 hunks)
  • runagent-go/runagent/version.go (1 hunks)
  • runagent-rust/runagent/Cargo.toml (1 hunks)
  • runagent-ts/package.json (1 hunks)
  • runagent/__init__.py (1 hunks)
  • runagent/__version__.py (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sawradip sawradip merged commit 5aa2fff into main Nov 13, 2025
1 of 2 checks passed
This was referenced Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant