Fix #1774: refresh folder list after disabling Unread Only#1794
Open
Keegil wants to merge 1 commit into
Open
Conversation
Re-run message list filtering even when the current filtered list is empty so turning off Unread Only repopulates the folder view without a local index. Add regression coverage for the filter refresh path.\n\n#1774
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fix — Message list stays empty after disabling Unread Only when no unread messages exist in the folder.
Problem
When a folder contained no unread messages, enabling Unread Only produced an empty list (expected). Disabling Unread Only afterwards left the list empty instead of repopulating it with all messages. The issue only occurred in this specific state (empty filtered result set, no local index). Issue #1774.
Fix
Testing
npm run lintpasses (existing repo-wide warnings only)npx ng build runbox7succeedsFixes #1774