fix(webmail): Only recount folder unread counts after content change #653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should help with 10sec pauses/slow down when folders with large contents exist.
tadzik
reviewed
Jun 30, 2020
| if (hasChanges) { | ||
| this.messagesInViewSubject.next(this.folderMessageLists[this.currentFolder]); | ||
| this.refreshFolderList(); | ||
| console.log('New/Moved messages, updating folder counts'); |
Contributor
There was a problem hiding this comment.
I assume this is left out intentionally, to ease the debugging in near future?
Contributor
Author
There was a problem hiding this comment.
Yes that was my thought
gtandersen
approved these changes
Jul 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should help with 10sec pauses/slow down when folders with large
contents exist.