Skip to content

Fix version in RunCat365.csproj#219

Merged
Kyome22 merged 1 commit into
runcat-dev:mainfrom
mor39a:main
Aug 8, 2025
Merged

Fix version in RunCat365.csproj#219
Kyome22 merged 1 commit into
runcat-dev:mainfrom
mor39a:main

Conversation

@mor39a
Copy link
Copy Markdown
Collaborator

@mor39a mor39a commented Aug 7, 2025

Type of Contribution

  • Bug Fix
  • New Feature
  • Refactoring

Summary of the Proposal

Fix/update the version in de RunCat365.csproj from v3.0.0 to actual v3.0.2

Reason for the new feature pull request

Since this information is used in the Information section of the menu:
https://github.com/Kyome22/RunCat365/blob/4ea49b6a4da65a40287cc7edfe07f388aa715b91/RunCat365/ContextMenuManager.cs#L112-L114
It can create confusion when users want to report bugs.

Checklist

  • Code follows proper indentation and naming conventions.
  • Works correctly in both dark theme and light theme.
  • Works correctly on any device.

@mor39a mor39a changed the title Fix version in RunCat.csproj Fix version in RunCat365.csproj Aug 7, 2025
@Kyome22
Copy link
Copy Markdown
Collaborator

Kyome22 commented Aug 8, 2025

@mor39a Thanks for your pull request.
I see, so this problem occurred because both the RunCat365 and WapForStore solutions are managing their versions independently. Since this mistake is prone to recurring repeatedly due to human error, we should either refer to a single reliable resource (SSOT) or implement automatic version number incrementation.

@mor39a
Copy link
Copy Markdown
Collaborator Author

mor39a commented Aug 8, 2025

@Kyome22 I've never done it, so I don't know how to do it. But I agree with you.

@Kyome22
Copy link
Copy Markdown
Collaborator

Kyome22 commented Aug 8, 2025

It seems that it is better to create an MSBuild project properties file and make it a reference format.

<Project>
  <PropertyGroup>
    <VersionPrefix>3.0.2</VersionPrefix>
    <VersionSuffix>0</VersionSuffix>
  </PropertyGroup>
</Project>

@Kyome22
Copy link
Copy Markdown
Collaborator

Kyome22 commented Aug 8, 2025

For now, I will merge this. I will implement a proper system myself.

@Kyome22 Kyome22 merged commit 7990ebf into runcat-dev:main Aug 8, 2025
@mor39a
Copy link
Copy Markdown
Collaborator Author

mor39a commented Aug 8, 2025

Ok, thanks

@Kyome22
Copy link
Copy Markdown
Collaborator

Kyome22 commented Aug 9, 2025

I couldn't get a shared version number to work between the RunCat365 and WapForStore projects. The WapForStore appxmanifest file requires a hardcoded version string and doesn't support variables. Automating this with GitHub Actions or Git Hooks seems like overkill, so I've decided to drop the idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants