Fix startup for Microsoft Store

[mor39a]

Type of Contribution

• Bug Fix
• New Feature
• Refactoring

Summary of the Proposal

Starting from Issue #216 and PR #220 I was investigating and testing different ways and I found this one to be able to configure Launch at Startup when it is packaged for the Microsoft Store.

Reason for the new feature

Launch at startup is a very useful feature that I wouldn't want to lose.

Checklist

• Code follows proper indentation and naming conventions.
• Works correctly in both dark theme and light theme.
• Works correctly on any device. -> Regarding this point, I have only had the opportunity to test it on Windows 10

Close Issues

• Close [Bug]: App doesn't launch at startup #226

[Kyome22]

There are many unnecessary changes throughout, such as adjustments to indentation and line order. Please keep your changes to a minimum and avoid disrupting the code's formatting.

[mor39a]

@Kyome22 I appreciate your feedback, unfortunately this weekend I will not be able to implement them. If there is no problem, I will do it on Monday.

[mor39a]

There are many unnecessary changes throughout, such as adjustments to indentation and line order. Please keep your changes to a minimum and avoid disrupting the code's formatting.

I think some changes were made by my IDE, I'll be more attentive thanks.

[Kyome22]

I appreciate your feedback, unfortunately this weekend I will not be able to implement them. If there is no problem, I will do it on Monday.

Thank you for your willingness to contribute to the app. Please feel free to take your time and don't feel rushed. (That said, it would be great if you could aim for about two weeks, otherwise I might lose track of the details (lol).)

[mor39a]

Thank you. In any case, I don't think I'll take long. The most difficult and time-consuming part was researching and it's done, correcting shouldn't take me long.

[Kyome22]

close #226

[mor39a]

There are many unnecessary changes throughout, such as adjustments to indentation and line order. Please keep your changes to a minimum and avoid disrupting the code's formatting.

@Kyome22 As I mentioned, it was Visual Studio that changed the format, which affected what you mentioned.
I found a solution and it is to use an .editorconfig file to unify the formatting across the project, so any contributor who wants to contribute can do so without affecting the formatting.

Before I implement it, what do you think about it?
The file would look something like this:

root = true

# C# files
[*.cs]
charset = utf-8-bom
indent_style = space
indent_size = 4
insert_final_newline = true
trim_trailing_whitespace = true

################################
# CODE FORMATTING
################################

# Braces always on new line
csharp_preserve_single_line_blocks = false
csharp_preserve_single_line_statements = true
csharp_new_line_before_open_brace = all
csharp_new_line_before_else = true
csharp_new_line_before_catch = true
csharp_new_line_before_finally = true
csharp_new_line_before_members_in_object_initializers = true
csharp_new_line_before_members_in_anonymous_types = true
csharp_new_line_between_query_expression_clauses = true
csharp_new_line_between_members_of_anonymous_types = true
csharp_new_line_between_members_of_object_initializers = true
csharp_new_line_within_query_expression_clauses = true

# Indentation
csharp_indent_case_contents = true
csharp_indent_switch_labels = true
csharp_indent_labels = flush_left

# Spacing
csharp_space_after_keywords_in_control_flow_statements = true
csharp_space_between_method_declaration_parameter_list_parentheses = false
csharp_space_between_method_call_parameter_list_parentheses = false
csharp_space_after_comma = true
csharp_space_after_dot = false
csharp_space_after_semicolon_in_for_statement = true
csharp_space_around_binary_operators = before_and_after
csharp_space_after_cast = false

# Parentheses
csharp_space_between_parentheses = false
csharp_space_between_attribute_brackets = false

################################
# CODE STYLE
################################

# var usage (allowed everywhere)
csharp_style_var_for_built_in_types = true:suggestion
csharp_style_var_when_type_is_apparent = true:suggestion
csharp_style_var_elsewhere = true:suggestion

# this. qualification (not required)
dotnet_style_qualification_for_field = false:suggestion
dotnet_style_qualification_for_property = false:suggestion
dotnet_style_qualification_for_method = false:suggestion
dotnet_style_qualification_for_event = false:suggestion

# Using directives
dotnet_sort_system_directives_first = true:error
dotnet_separate_import_directive_groups = true:error
dotnet_remove_unnecessary_usings = true:error

# Null handling
dotnet_style_null_propagation = true:warning
dotnet_style_coalesce_expression = true:warning

# Prefer "is null" over == null
csharp_style_prefer_is_null_check_over_reference_equality_method = true:error

################################
# FILE HEADER
################################
file_header_template = Copyright 2020 Takuto Nakamura\n\n    Licensed under the Apache License, Version 2.0 (the "License")\n    you may not use this file except in compliance with the License.\n    You may obtain a copy of the License at\n\n        http://www.apache.org/licenses/LICENSE-2.0\n\n    Unless required by applicable law or agreed to in writing, software\n    distributed under the License is distributed on an "AS IS" BASIS,\n    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n    See the License for the specific language governing permissions and\n    limitations under the License.

[mor39a]

@Kyome22 I've implemented the comments you gave me. I look forward to further feedback and your opinion on editorconfig.

[Kyome22]

There are many unnecessary changes throughout, such as adjustments to indentation and line order. Please keep your changes to a minimum and avoid disrupting the code's formatting.

@Kyome22 As I mentioned, it was Visual Studio that changed the format, which affected what you mentioned. I found a solution and it is to use an .editorconfig file to unify the formatting across the project, so any contributor who wants to contribute can do so without affecting the formatting.

@mor39a This is a great suggestion. I'm all for introducing a linter and formatter.

However, since that is a significant topic on its own, I would prefer to handle it in a separate issue or pull request. I anticipate that applying them will generate a large number of diffs in existing files.

If you'd like to work on this first, please open a new PR specifically for it.

[mor39a]

If you'd like to work on this first, please open a new PR specifically for it.

I will, thank you.

---

Regarding the current PR, do you have feedback for me?

[Kyome22]

Regarding the current PR, do you have feedback for me?

I’ve provided feedback on the overall architecture of this feature. Lately, I’ve been really immersed in architecture thinking, so my scrutiny might be a bit harsh. I apologize for that.

[mor39a]

Regarding the current PR, do you have feedback for me?

I’ve provided feedback on the overall architecture of this feature. Lately, I’ve been really immersed in architecture thinking, so my scrutiny might be a bit harsh. I apologize for that.

Don't worry. Thanks for your feedback, I will work on it.

[Kyome22]

LGTM