Implement local rankings system in endless game#259
Merged
Conversation
Kyome22
reviewed
Nov 27, 2025
Kyome22
reviewed
Nov 27, 2025
Collaborator
|
The idea itself is good and I'd like to incorporate it if possible, but my concern is that it would increase the amount of information displayed on the screen, making it cluttered. |
Kyome22
reviewed
Dec 1, 2025
Collaborator
|
@Sogeum100g When a high score is achieved, I want to display "New Record!!" instead of "Game Over." Also, I'd like to have the high score and current score stacked vertically in the top-right corner. |
Contributor
Author
I applied it |
Collaborator
|
@Sogeum100g Thanks for the update. Could you please rebase the latest main branch and resolve the conflicts? |
Collaborator
|
There are still some conflicts. |
Contributor
Author
|
It looks like multi-language support was added. I've updated it to reflect that. |
Kyome22
reviewed
Jan 17, 2026
Kyome22
reviewed
Jan 17, 2026
Kyome22
reviewed
Jan 17, 2026
Co-authored-by: Takuto NAKAMURA (Kyome) <kyomesuke@gmail.com>
Co-authored-by: Takuto NAKAMURA (Kyome) <kyomesuke@gmail.com>
Removed merge conflict markers and cleaned up settings.
Kyome22
approved these changes
Feb 5, 2026
Collaborator
Kyome22
left a comment
Kyome22
left a comment
There was a problem hiding this comment.
LGTM
I'll fix the minor details on my end.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context of Contribution
Summary of the Proposal
Users can record and challenge their own high score in your local running
Reason for the new feature
#221
Checklist