Enhancing the foundation for multi-language support.#270
Merged
Conversation
Collaborator
Author
|
Noto Sans JP Consolas |
Kyome22
force-pushed
the
create-supported-language-enum
branch
from
c9b7779 to
16562a4
Compare
Collaborator
Author
|
Modified |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context of Contribution
Summary of the Proposal
Allow the specification of appropriate fonts for each language.
Improve the handling of supported languages to be type-safe.
Reason for the new feature
Using the Consolas font for Japanese was not ideal. The line spacing was too tight, making it difficult to read. Therefore, I will switch to Noto Sans JP for Japanese.
Checklist