Feature/speed source selection#271
Merged
Kyome22 merged 4 commits intoJan 24, 2026
Merged
Conversation
Collaborator
|
This PR depends on #272, so I'll keep it as a draft for now. |
b6ac821 to
dd2c341
Compare
2 tasks
Collaborator
|
@Anandb71 Could you please attach some screenshots? |
Contributor
Author
Contributor
Author
|
Hey @Kyome22 , Even though I set 'speed based on' to GPU/Memory, the hover still shows CPU %. Should I change it? |
Collaborator
Good catch! If the speed is based on the GPU/Memory, the hover message should be synced with it as well. |
Contributor
Author
|
done! @Kyome22 |
Kyome22
reviewed
Jan 24, 2026
Contributor
Author
|
Done! and tested! |
Kyome22
approved these changes
Jan 24, 2026
Collaborator
Kyome22
left a comment
There was a problem hiding this comment.
There are several things I'd like to fix, but functionally it looks good, so LGTM.
Collaborator
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Context of Contribution
Summary of the Proposal
Add user setting to choose what metric (CPU, GPU, or Memory) determines the cat's running speed. Adds a "Speed based on" submenu in Settings with radio-style selection. GPU option is hidden if GPU monitoring is unavailable.
Reason for the new feature
Checklist