Skip to content

Feature/speed source selection#271

Merged
Kyome22 merged 4 commits into
runcat-dev:mainfrom
Anandb71:feature/speed-source-selection
Jan 24, 2026
Merged

Feature/speed source selection#271
Kyome22 merged 4 commits into
runcat-dev:mainfrom
Anandb71:feature/speed-source-selection

Conversation

@Anandb71
Copy link
Copy Markdown
Contributor

Context of Contribution

  • Bug Fix
  • Refactoring
  • New Feature
  • Others

Summary of the Proposal

Add user setting to choose what metric (CPU, GPU, or Memory) determines the cat's running speed. Adds a "Speed based on" submenu in Settings with radio-style selection. GPU option is hidden if GPU monitoring is unavailable.

Reason for the new feature

  • Requested by maintainer: allow users to configure which metric affects speed
  • Some users prefer GPU load to drive animation (gamers, GPU-intensive work)
  • Some users prefer Memory usage (developers with many apps open)
  • Default remains CPU for backward compatibility
  • GPU option automatically hidden if Performance Counters unavailable
  • Minimal UI: simple radio submenu in existing Settings menu

Checklist

  • This PR does not contain commits of multiple contexts.
  • Code follows proper indentation and naming conventions.
  • Implemented using only APIs that can be submitted to the Microsoft Store.
  • Works correctly in both dark theme and light theme.
  • Works correctly on any device.

@Kyome22 Kyome22 marked this pull request as draft January 11, 2026 15:08
@Kyome22
Copy link
Copy Markdown
Collaborator

Kyome22 commented Jan 11, 2026

This PR depends on #272, so I'll keep it as a draft for now.

@Anandb71 Anandb71 force-pushed the feature/speed-source-selection branch from b6ac821 to dd2c341 Compare January 13, 2026 14:40
@Kyome22 Kyome22 marked this pull request as ready for review January 23, 2026 04:44
@Kyome22
Copy link
Copy Markdown
Collaborator

Kyome22 commented Jan 23, 2026

@Anandb71 Could you please attach some screenshots?

@Anandb71
Copy link
Copy Markdown
Contributor Author

Anandb71 commented Jan 23, 2026

image

@Anandb71
Copy link
Copy Markdown
Contributor Author

Hey @Kyome22 , Even though I set 'speed based on' to GPU/Memory, the hover still shows CPU %. Should I change it?

@Kyome22
Copy link
Copy Markdown
Collaborator

Kyome22 commented Jan 24, 2026

Hey @Kyome22 , Even though I set 'speed based on' to GPU/Memory, the hover still shows CPU %. Should I change it?

Good catch! If the speed is based on the GPU/Memory, the hover message should be synced with it as well.

@Anandb71
Copy link
Copy Markdown
Contributor Author

done! @Kyome22

Comment thread RunCat365/Program.cs Outdated
@Anandb71
Copy link
Copy Markdown
Contributor Author

Done! and tested!

Copy link
Copy Markdown
Collaborator

@Kyome22 Kyome22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are several things I'd like to fix, but functionally it looks good, so LGTM.

@Kyome22 Kyome22 merged commit 24ad664 into runcat-dev:main Jan 24, 2026
@Kyome22
Copy link
Copy Markdown
Collaborator

Kyome22 commented Jan 24, 2026

GPUInfo.Total did not exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants