Set CurrentCulture to match UI language for locale-aware number formatting#286
Merged
Conversation
…tting Spanish UI now shows comma as decimal separator (e.g. 85,3%, 1,5 GB), while English and Japanese UI use period as before. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context of Contribution
Summary of the Proposal
Set
CultureInfo.CurrentCultureat startup to match the current UI language, so that number formatting (decimal separator, etc.) follows the display language's conventions.Reason for the new feature
Spanish localization was recently added, but Spanish uses a comma as the decimal separator (e.g.
85,3%,1,5 GB) rather than a period. Previously, number formatting always followed the Windows system regional settings, independent of the app's UI language. This meant users running a Spanish UI on an English-configured system would still see period-separated numbers, which is incorrect..NET separates UI language (
CurrentUICulture) from number/date formatting (CurrentCulture). By explicitly settingCurrentCultureto the culture that corresponds to the selected UI language, the app now behaves consistently — the same way iOS automatically ties number formatting to the active Locale.This is a one-line change that reuses the existing
SupportedLanguageExtension.GetDefaultCultureInfo()utility, with no modifications needed toByteFormatteror the Repository classes.Checklist