Skip to content
This repository was archived by the owner on Oct 2, 2023. It is now read-only.

Skip app check for ringtools#32

Merged
WilliamConnatser merged 3 commits intomainfrom
fix/ringtools-starting
Jul 9, 2022
Merged

Skip app check for ringtools#32
WilliamConnatser merged 3 commits intomainfrom
fix/ringtools-starting

Conversation

@AaronDewes
Copy link
Copy Markdown
Contributor

Even with the CORS fix, the app was still shown as "starting". So this will work as a temporary workaround for 0.0.5

Even with the CORS fix, the app was still shown as "starting". So this will work as a temporary workaround for 0.0.5
@pwltr
Copy link
Copy Markdown
Contributor

pwltr commented Jun 7, 2022

The same logic should be added to AppStoreApp.vue that also contains the polling. A fallback idea to work around this CORS issue would be to work with the manager to check for container status with something like docker container inspect -f '{{.State.Status}}' ringtools-main-1. It's not as good an end-to-end check as the current HTTP request polling but it would work around the CORS/CORP issues. It also might come in handy for apps that don't have a web UI.

@pwltr
Copy link
Copy Markdown
Contributor

pwltr commented Jun 7, 2022

We should also add some screenshots for this app.

@AaronDewes
Copy link
Copy Markdown
Contributor Author

Sure, they can be added later. Will update the AppStoreApp code though.

Comment thread src/components/InstalledApp.vue
@AaronDewes AaronDewes requested a review from pwltr July 8, 2022 13:53
@WilliamConnatser WilliamConnatser merged commit e232279 into main Jul 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants