This repository was archived by the owner on Oct 2, 2023. It is now read-only.
Lint --fix ignored files#104
Merged
WilliamConnatser merged 1 commit intomainfrom May 19, 2022
Merged
Conversation
AaronDewes
approved these changes
May 18, 2022
Contributor
Author
I assumed it was something like that, I looked for other lnd folders but there was only this one so I removed the .ignore entry. Full disclosure for this commit, it was mostly normal lint errors but also 2 instances of "no-confusing-void-expression" which might have also been bugs but I don't think the responses are used anywhere. closeChannel returns Promise of void, so this is basically assignment to void: ctx.body = await lightningLogic.closeChannel(fundingTxId, index, force);changed to this: await lightningLogic.closeChannel(fundingTxId, index, force);
ctx.body = {success: true};and a second case like this. |
WilliamConnatser
approved these changes
May 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linted some files that where ignored by xo