Skip to content
This repository was archived by the owner on Oct 2, 2023. It is now read-only.

Lint --fix ignored files#104

Merged
WilliamConnatser merged 1 commit intomainfrom
fix/lint-errors
May 19, 2022
Merged

Lint --fix ignored files#104
WilliamConnatser merged 1 commit intomainfrom
fix/lint-errors

Conversation

@pwltr
Copy link
Copy Markdown
Contributor

@pwltr pwltr commented May 18, 2022

Linted some files that where ignored by xo

Copy link
Copy Markdown
Contributor

@AaronDewes AaronDewes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why this was even in there, probably a leftover from Umbrel or Casa.

(Edit: It was me, we had a top-level LND dir and I only wanted to ignore that, I didn't know I had to put a / when I made that commit)

@pwltr
Copy link
Copy Markdown
Contributor Author

pwltr commented May 18, 2022

I don't know why this was even in there, probably a leftover from Umbrel or Casa.
(Edit: It was me, we had a top-level LND dir and I only wanted to ignore that, I didn't know I had to put a / when I made that commit)

I assumed it was something like that, I looked for other lnd folders but there was only this one so I removed the .ignore entry.

Full disclosure for this commit, it was mostly normal lint errors but also 2 instances of "no-confusing-void-expression" which might have also been bugs but I don't think the responses are used anywhere.

closeChannel returns Promise of void, so this is basically assignment to void:

ctx.body = await lightningLogic.closeChannel(fundingTxId, index, force);

changed to this:

await lightningLogic.closeChannel(fundingTxId, index, force);
ctx.body = {success: true};

and a second case like this.

@WilliamConnatser WilliamConnatser merged commit 90736e1 into main May 19, 2022
@pwltr pwltr deleted the fix/lint-errors branch May 19, 2022 06:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants