fix(webhooks): post-review polish on v0.1.25.39 emits (v0.1.25.40)#146
Merged
Conversation
….25.40)
Follow-up correctness pass on the v0.1.25.39 webhook lifecycle Event
work. All four items from the post-merge review:
B1 — Actor parity. Single-op create/update/delete now populate
Actor.keyId from authenticated_key_id, matching the bulk-action
path. Audit consumers see consistent API-key attribution on every
webhook lifecycle Event regardless of code path.
B2/B3 — changed_fields is now a true diff. Previously any field
present in the PATCH body was recorded even when the value
matched the subscription's current value. Now each request-
provided field is compared against the prior snapshot; only
genuine mutations land in changed_fields. signing_secret keeps
presence-based detection (stored value is encrypted and not
safely comparable to the plaintext request value). Consequence:
a full-identity PATCH (every field resent with existing value,
no status flip) is a true no-op — aligns with spec v0.1.25.33
§6281.
B4 — Correlation-id uniqueness. The "no-req" literal fallback in
webhook_update:<sub_id>:<request_id> and
webhook_bulk_action:<action>:<request_id> is replaced with a
req_<uuid> fallback. Guarantees uniqueness if RequestIdFilter
ever fails to populate the attribute.
Internal-only fixes. No EventType / schema / endpoint / wire-format
changes.
amavashev
added a commit
that referenced
this pull request
May 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Post-merge review polish on v0.1.25.39 webhook lifecycle Events (PR #145). Fixes the four items from the review pass — all internal correctness, no spec/wire changes.
create/update/deleteemits now populateActor.keyIdfromauthenticated_key_id, matching the bulk path. Audit consumers see consistent API-key attribution across all webhook lifecycle paths.changed_fieldsis now a real diff vs the prior snapshot instead of request-presence. Identity-PATCHes emit with emptychanged_fields; full-identity PATCHes (no status flip) are true no-ops and emit nothing — aligns with spec v0.1.25.33 §6281.signing_secretkeeps presence-based detection (stored value is encrypted; not safely comparable to plaintext request value)."no-req"literal correlation-id fallback replaced withreq_<uuid>. Guarantees uniqueness under misconfiguredRequestIdFilter.Test plan
WebhookAdminControllerTestgreen — 58 tests including 4 new B1/B2/B3/B4 regression casescycles-admin-service/pom.xmlbumped to 0.1.25.40