Claude/fix hero image visibility ofl m4#53
Merged
Conversation
VitePress uses absolute positioning for .image-src inside a fixed-dimension .image-container. Previous CSS broke this by overriding container dimensions and removing positioning context. Now works with VitePress's layout by only increasing the max-width/max-height on .image-src at each breakpoint: - mobile: 192→280px - tablet: 256→340px - desktop: 320→420px https://claude.ai/code/session_01WcCDNp5tZVqpaNxancVdRc
:deep() is a Vue scoped style selector and has no effect in a plain CSS file. Replaced with standard class selectors which will correctly match the rendered .image-src element. https://claude.ai/code/session_01WcCDNp5tZVqpaNxancVdRc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SVG: viewBox 620x500, transparent background (fill="none") — no white box in dark mode
CSS: Only overrides max-width/max-height on .image-src at each VitePress breakpoint:
Mobile: 192→280px
Tablet (640px+): 256→340px
Desktop (960px+): 320→420px
Removes .image-bg circle decoration
Clears .image-container background/box-shadow/border for dark mode
Sets brand color to teal #00C9A7
Also caught that :deep() doesn't work in plain CSS files — fixed to standard class selectors.