PvP Performance Tracker: UI improvements, reformat magic luck%, always use LMS config in LMS#1013
Merged
Conversation
|
|
mostly based on feedback recommit: small fix.
Matsyir
force-pushed
the
pvp-performance-tracker
branch
from
ac62c50 to
e43c4a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly some minor UI improvements based on feedback, related to the recent updates' changes. Reformatted the magic luck% again, so that now 100% is the "expected hits/luck", <100% is unlucky, >100% is lucky. Previously, 0% was the expected hits/neutral point.
LMS no longer uses the config for levels, ring and bolt settings, it always uses the fixed settings of: 118att 118str 75def 112range 99mage, Berserker ring, and regular diamond bolts(e) with any crossbow. So, if your level config is set as 1 attack/str/def/etc, you will still have the correct levels, ring, and bolts that are actually used in LMS regardless of your config. Due to this, the default defence level has been updated to 120 since this is likely the most common outside of LMS.
Fixed an issue where if an opponent ran out of render distance, the fight would split into a new one when they came back, as the opponent was not recognized as the same player when coming back (may have only been an issue in duel arena? not certain, but confirmed fixed in duel arena). Once again tested in LMS with
-ea& dev tools enabled. v1.4.1 from 1.4.0.