Skip to content

Bug fixes and refactor better npc highlight#10290

Merged
riktenx merged 1 commit into
runelite:masterfrom
SamuelDev:better-npc-highlight-refactor
Jan 26, 2026
Merged

Bug fixes and refactor better npc highlight#10290
riktenx merged 1 commit into
runelite:masterfrom
SamuelDev:better-npc-highlight-refactor

Conversation

@SamuelDev
Copy link
Copy Markdown
Contributor

@SamuelDev SamuelDev commented Jan 22, 2026

For the long term health of this plugin it needed a large refactor to be more maintainable both by me and anyone else that decides to contribute. I apologize for the huge diff from this. In addition to refactoring I fixed some bugs that existed while doing so.

While doing a release for primarily a refactor may seem unnecessary, I did include a few bug fixes at the same time which warrants a release. I also did not want to hold these changes back from releasing, as it would just make the next one have an even larger diff with the additional changes it would bring.

Changes:

  • Refactored entire codebase, separating facets of the plugin out into logical managers and data objects
  • Made the codebase rely more heavily on dependency injection rather than passing objects around
  • New helper functions for config management
  • Multiple bug fixes in the right click menu around color selection and tags on the menu entry strings
  • Fixed a turbo mode bug that could result in log spam due to accessing a null object as well as an index out of bounds error

@runelite-github-app
Copy link
Copy Markdown

@runelite-github-app
Copy link
Copy Markdown

This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed.


Internal use only: Reviewer details Maintainer details

@riktenx riktenx merged commit 72fbead into runelite:master Jan 26, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants