Bug fixes and refactor better npc highlight#10290
Merged
Merged
Conversation
|
|
|
This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed. Internal use only: Reviewer details Maintainer details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the long term health of this plugin it needed a large refactor to be more maintainable both by me and anyone else that decides to contribute. I apologize for the huge diff from this. In addition to refactoring I fixed some bugs that existed while doing so.
While doing a release for primarily a refactor may seem unnecessary, I did include a few bug fixes at the same time which warrants a release. I also did not want to hold these changes back from releasing, as it would just make the next one have an even larger diff with the additional changes it would bring.
Changes: