Add osrs-tracker plugin#10296
Conversation
|
New plugin |
19fe654 to
6e4070c
Compare
|
This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed. Internal use only: Reviewer details Maintainer details |
|
log.info every frame (or every n frames) such as in your draw listener is not OK. basically all of your log.infos should be debug |
Fixed! Changed all frequent log.info to log.debug, and completely removed logging from the per-frame capture path (captureFrame/encodeAndStoreFrame). No logging of any kind runs at 30 FPS now - only plugin startup/shutdown and actual game events (level ups, loot, deaths, etc.) use log.info. |
|
You rewrote your commit history when you made this change, rather than just pushing a new commit. I cannot see the difference between what you had submitted before and now, which means I basically have to re-review your entire ~4-thousand line plugin. That is absurdly annoying. Do not do that. |
That is really annoying, I unintentionally copied the branch rules for an in-house tool squashing all merges, I apologise for the inconvenience. It won't happen again. |
|
if 4fe343e6139f5bdbf908ecf8e14bb1fbb6d0f690 is the previous change you can use the following to clean up the diffs |
Thank you so much for this suggestion, I was able to revert to the previous hash and restore the commits, I updated the commit hash for the plugin-hub. |
OSRS Tracker - Automatically tracks gameplay events and sends them to osrs-tracker.com
Features: