Skip to content

Add osrs-tracker plugin#10296

Merged
riktenx merged 7 commits into
runelite:masterfrom
dennisdevulder:master
Jan 29, 2026
Merged

Add osrs-tracker plugin#10296
riktenx merged 7 commits into
runelite:masterfrom
dennisdevulder:master

Conversation

@dennisdevulder
Copy link
Copy Markdown
Contributor

OSRS Tracker - Automatically tracks gameplay events and sends them to osrs-tracker.com

Features:

  • Level-up tracking with video replay
  • Quest completion tracking with video replay
  • Loot drops (100k+ GP configurable) with video replay
  • Clue scroll rewards with screenshots
  • Collection log updates with video replay
  • Death tracking with video replay
  • Item Snitch: alerts for shared clan items in bank

@runelite-github-app
Copy link
Copy Markdown

runelite-github-app Bot commented Jan 22, 2026

@runelite-github-app
Copy link
Copy Markdown

runelite-github-app Bot commented Jan 22, 2026

This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed.


Internal use only: Reviewer details Maintainer details

Comment thread plugins/osrs-tracker Outdated
Comment thread plugins/osrs-tracker Outdated
@riktenx
Copy link
Copy Markdown
Member

riktenx commented Jan 27, 2026

log.info every frame (or every n frames) such as in your draw listener is not OK. basically all of your log.infos should be debug

@riktenx riktenx added the waiting for author waiting for the pr author to make changes or respond to questions label Jan 27, 2026
@runelite-github-app runelite-github-app Bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Jan 28, 2026
@dennisdevulder
Copy link
Copy Markdown
Contributor Author

log.info every frame (or every n frames) such as in your draw listener is not OK. basically all of your log.infos should be debug

Fixed! Changed all frequent log.info to log.debug, and completely removed logging from the per-frame capture path (captureFrame/encodeAndStoreFrame). No logging of any kind runs at 30 FPS now - only plugin startup/shutdown and actual game events (level ups, loot, deaths, etc.) use log.info.

@riktenx
Copy link
Copy Markdown
Member

riktenx commented Jan 29, 2026

You rewrote your commit history when you made this change, rather than just pushing a new commit. I cannot see the difference between what you had submitted before and now, which means I basically have to re-review your entire ~4-thousand line plugin. That is absurdly annoying. Do not do that.

@dennisdevulder
Copy link
Copy Markdown
Contributor Author

You rewrote your commit history when you made this change, rather than just pushing a new commit. I cannot see the difference between what you had submitted before and now, which means I basically have to re-review your entire ~4-thousand line plugin. That is absurdly annoying. Do not do that.

That is really annoying, I unintentionally copied the branch rules for an in-house tool squashing all merges, I apologise for the inconvenience. It won't happen again.

@LlemonDuck
Copy link
Copy Markdown
Contributor

if 4fe343e6139f5bdbf908ecf8e14bb1fbb6d0f690 is the previous change you can use the following to clean up the diffs

git reset 4fe343e6139f5bdbf908ecf8e14bb1fbb6d0f690
git add .
git commit
git push --force-with-lease

@dennisdevulder
Copy link
Copy Markdown
Contributor Author

if 4fe343e6139f5bdbf908ecf8e14bb1fbb6d0f690 is the previous change you can use the following to clean up the diffs

git reset 4fe343e6139f5bdbf908ecf8e14bb1fbb6d0f690
git add .
git commit
git push --force-with-lease

Thank you so much for this suggestion, I was able to revert to the previous hash and restore the commits, I updated the commit hash for the plugin-hub.

@riktenx riktenx merged commit 4b02026 into runelite:master Jan 29, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants