Skip to content

Update arceuuscc plugin to 2.0.0#10342

Merged
riktenx merged 2 commits into
runelite:masterfrom
dc-m:master
Jan 31, 2026
Merged

Update arceuuscc plugin to 2.0.0#10342
riktenx merged 2 commits into
runelite:masterfrom
dc-m:master

Conversation

@dc-m
Copy link
Copy Markdown
Contributor

@dc-m dc-m commented Jan 26, 2026

Added access request/approval authentication (no password required) to allow api post/patch/delete protection

Updated the commit reference for the arceuuscc plugin.
@runelite-github-app
Copy link
Copy Markdown

runelite-github-app Bot commented Jan 26, 2026

@runelite-github-app
Copy link
Copy Markdown

runelite-github-app Bot commented Jan 26, 2026

This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed.


Internal use only: Reviewer details Maintainer details

@dc-m dc-m changed the title Change commit reference in arceuuscc plugin 2.0.0 Update arceuuscc plugin to 2.0.0 Jan 26, 2026
@LlemonDuck
Copy link
Copy Markdown
Contributor

LlemonDuck commented Jan 26, 2026

to keep your build process as standardized as possible, it would be better to just use an envvar or something to control the environment switching. running through intellij/vsc will allow you to add the envvar whereas a regular user cannot do so via the launcher. you don't need separate build logic just for this

@LlemonDuck LlemonDuck added the waiting for author waiting for the pr author to make changes or respond to questions label Jan 26, 2026
@dc-m
Copy link
Copy Markdown
Contributor Author

dc-m commented Jan 26, 2026

to keep your build process as standardized as possible, it would be better to just use an envvar or something to control the environment switching. running through intellij/vsc will allow you to add the envvar whereas a regular user cannot do so via the launcher. you don't need separate build logic just for this

yeah ill look at sorting that now, to be honest i was tempted to just remove it and deal with this later as i wasnt sure it was right either, so ill do that for now.

@runelite-github-app runelite-github-app Bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Jan 26, 2026
@riktenx riktenx merged commit 1b1a67a into runelite:master Jan 31, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants