Skip to content

Update custom-emoji#10447

Merged
riktenx merged 1 commit into
runelite:masterfrom
Fiffers:master
Feb 4, 2026
Merged

Update custom-emoji#10447
riktenx merged 1 commit into
runelite:masterfrom
Fiffers:master

Conversation

@Fiffers
Copy link
Copy Markdown
Contributor

@Fiffers Fiffers commented Feb 3, 2026

This PR includes a couple of bug fixes:

  • Add missing padding to the latest message when we need to scooch the messages down. It made more sense for this functionality to be in the scrolling manager, so I moved the logic to that class.
  • Fix bug causing positions to be incorrect after toggling resize mode on an emoji. Refactored the cache clearing methods in the rendering classes a bit to handle problems like this better in the future.

Moved the methods around a bit in some of the classes so they're in public -> protected -> private order.
Extracted a couple methods to the PluginUtils class as well

@runelite-github-app
Copy link
Copy Markdown

@runelite-github-app
Copy link
Copy Markdown

This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed.


Internal use only: Reviewer details Maintainer details

@riktenx riktenx merged commit e42f5de into runelite:master Feb 4, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants