Update custom-emoji#10461
Merged
Merged
Conversation
|
This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed. Internal use only: Reviewer details Maintainer details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
CustomEmojiPluginclass is a complete spaghetti mess, so this PR implements an optional newEmojiLoaderclass that handles most of the emoji loading stuff instead. It still has some bugs that I need to sort out, so I've left the old loader stuff in for now.New stuff:
BeforeEmojisLoadedandAfterEmojisLoadedevents to better decouple the loading processEmojiLoaderbecause it's easier to parse what's going on if you're not trying to read a 2000-line fileFileUtilsjust to hold on to some useful static methods for file io stuffEmojiDtodedicated data-transfer object for dedicatedly data transferring stuff between objects (File IO -> Emoji)Changed stuff:
AnimatedEmojiandStaticEmojiclasses to be able to use a builder pattern