Skip to content

Update custom-emoji#10461

Merged
riktenx merged 1 commit into
runelite:masterfrom
Fiffers:master
Feb 5, 2026
Merged

Update custom-emoji#10461
riktenx merged 1 commit into
runelite:masterfrom
Fiffers:master

Conversation

@Fiffers
Copy link
Copy Markdown
Contributor

@Fiffers Fiffers commented Feb 5, 2026

The CustomEmojiPlugin class is a complete spaghetti mess, so this PR implements an optional new EmojiLoader class that handles most of the emoji loading stuff instead. It still has some bugs that I need to sort out, so I've left the old loader stuff in for now.

New stuff:

  • BeforeEmojisLoaded and AfterEmojisLoaded events to better decouple the loading process
  • EmojiLoader because it's easier to parse what's going on if you're not trying to read a 2000-line file
  • FileUtils just to hold on to some useful static methods for file io stuff
  • EmojiDto dedicated data-transfer object for dedicatedly data transferring stuff between objects (File IO -> Emoji)
  • A new config option to toggle between the old and new loader

Changed stuff:

  • Updated the AnimatedEmoji and StaticEmoji classes to be able to use a builder pattern

@runelite-github-app
Copy link
Copy Markdown

@runelite-github-app
Copy link
Copy Markdown

This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed.


Internal use only: Reviewer details Maintainer details

@riktenx riktenx merged commit 3c78fb3 into runelite:master Feb 5, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants