Update custom-emoji#10477
Merged
Merged
Conversation
|
This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed. Internal use only: Reviewer details Maintainer details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a few bug fixes for the new
EmojiLoaderstuff and extracts the download progress bar stuff into its own class that uses the event bus for updates. Progress bars are neat.There's never really been a good way to show the users that the emoji were loading so there were some instances where they thought something was broken when it was not. Hopefully this helps with that issue.
I've been noticing that I keep getting the
idandimageIdproperties in theEmojiinterface mixed up so I renamed them toindexandiconIdrespectively to align with what theChatIconManagercalls them. Sidenote, I get these mixed up so often that the entire codebase has them flip-flopped(big oof). Because of this, I have them assigned backwards in the DTO class for theEmojiLoaderstuff, since its using them correctly. That's a problem for future me.Automatic downloads have been reimplemented.
Also included in this PR is a bugfix for the
CustomEmojiOverlay. Since there's a lot of different things that use theMESLAYERINPUTvar, the overlay would show up when it shouldn't. For example, this would happen when searching fairy ring codes or typing the name of a friends chat channel you're trying to join. This bug has been fixed :)