Skip to content

Add auto-entity-hider#10487

Merged
geheur merged 5 commits into
runelite:masterfrom
P2GR:autoentityhider
Feb 7, 2026
Merged

Add auto-entity-hider#10487
geheur merged 5 commits into
runelite:masterfrom
P2GR:autoentityhider

Conversation

@P2GR
Copy link
Copy Markdown
Contributor

@P2GR P2GR commented Feb 6, 2026

Automatically enable a custom entity hider configuration when you enter certain regions/locations e.g. ToA boss rooms, GotR, GE

@runelite-github-app
Copy link
Copy Markdown

runelite-github-app Bot commented Feb 6, 2026

@runelite-github-app
Copy link
Copy Markdown

runelite-github-app Bot commented Feb 6, 2026

Internal use only: Reviewer details Maintainer details

@geheur
Copy link
Copy Markdown
Contributor

geheur commented Feb 6, 2026

modifying other plugins' config has caused issues in the past due to the many ways that configs can be changed, and with entity hider being such an impactful plugin, having it on at the wrong time due to a bug would suck. Have you considered copypasting entity hider and adding some region logic, and then making it exclusive with entity hider (in plugindescriptor conflicts field)?

@P2GR
Copy link
Copy Markdown
Contributor Author

P2GR commented Feb 6, 2026

modifying other plugins' config has caused issues in the past due to the many ways that configs can be changed, and with entity hider being such an impactful plugin, having it on at the wrong time due to a bug would suck. Have you considered copypasting entity hider and adding some region logic, and then making it exclusive with entity hider (in plugindescriptor conflicts field)?

Yeah can do that. the idea came from the plugin: Automatic Low Detail, which enables the Low Detail plugin in the same way.
That's why i thought it wouldn't really pose an issue.

What would you prefer?
Copy pasting entity hider and adding the region logic?

maybe adding a game chat message saying [Auto Entity Hider] Entered region: Grand Exchange would already suffice to make it clear to people what's going on?

@geheur
Copy link
Copy Markdown
Contributor

geheur commented Feb 6, 2026

having the wrong entity hider settings is a much bigger deal than low detail, I wouldn't risk it, and copypasting entity hider is not too difficult. Please do it that way instead. Chat message does not help, the concern is that the plugin might not restore settings when it should.

@P2GR
Copy link
Copy Markdown
Contributor Author

P2GR commented Feb 6, 2026

@geheur

updated the plugin and it now uses the native entity hider as utility class.
if you still have feedback, please let me know!

@geheur
Copy link
Copy Markdown
Contributor

geheur commented Feb 6, 2026

Looks ok to me but isn't this functionally different from before? It sets all fields to false when leaving a region but before it would use the entity hider plugin's config? Not a problem for accepting the plugin but idk if that's what you intended.

You could read the existing entity hider config for when you're outside of one of these regions. Or you could have a second set of config settings.

@raiyni
Copy link
Copy Markdown
Member

raiyni commented Feb 6, 2026

Exactly what use does this have that you would need different configs for different areas?

@P2GR
Copy link
Copy Markdown
Contributor Author

P2GR commented Feb 6, 2026

@raiyni

The idea came from a friend, who was annoyed that he had to constantly enable the entity hider manually for ToA wardens.

I personally always enable the entity hider at the GE and GotR. But i leave it on for everywhere else in the game.

This plugin just adds a small convenience/ automation to that.

@geheur geheur merged commit 8201806 into runelite:master Feb 7, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants