Skip to content

Update pvp-performance-tracker to v1.4.2#1053

Merged
Nightfirecat merged 1 commit into
runelite:masterfrom
Matsyir:pvp-performance-tracker
Feb 1, 2021
Merged

Update pvp-performance-tracker to v1.4.2#1053
Nightfirecat merged 1 commit into
runelite:masterfrom
Matsyir:pvp-performance-tracker

Conversation

@Matsyir

@Matsyir Matsyir commented Feb 1, 2021

Copy link
Copy Markdown
Contributor

UI improvements/fixes:

  • Allow dragging and dropping a file onto the fight data text field for fight analysis/merge (only tested on windows10)
  • Added HP to fight log detail frame (only really useful for fight analysis/merge, otherwise it's a static 99)
  • Added total HP healed to total stats panel
  • Updated magic hit luck on total stats panel so it displays the proper value
  • Sort fight attack logs by tick & generate time based on tick (rather than using timestamp) for more consistent/reliable durations, and proper sorting during fight merge (since the timestamps are inconsistent in that case, currently it makes the levels seem invalid in many cases but it's just improperly sorted in the table).

Minor fight analysis process/algorithm improvements, buuut there are still some odd edge cases that cause the fight analysis/merge to fail, though it does seem to work in the vast majority of normal cases. Here's an issue with more details if anyone would like to help with the issue/review the process.

There remains some "older" code to support older data while transitioning into this update, since I know there are some ongoing tournies that may want to re-analyze existing fights after this update. It will be removed later on.

UI improvements/fixed total stats panel, added hp to fight log details (only useful for the merge), sort logs by tick & create time by tick for more consistent durations and proper ordering in fight merge. Minor fight analysis process/algorithm improvements
@runelite-github-app

Copy link
Copy Markdown

@Nightfirecat Nightfirecat merged commit 482bdbd into runelite:master Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants