Update pvp-performance-tracker to v1.4.2#1053
Merged
Merged
Conversation
UI improvements/fixed total stats panel, added hp to fight log details (only useful for the merge), sort logs by tick & create time by tick for more consistent durations and proper ordering in fight merge. Minor fight analysis process/algorithm improvements
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UI improvements/fixes:
Minor fight analysis process/algorithm improvements, buuut there are still some odd edge cases that cause the fight analysis/merge to fail, though it does seem to work in the vast majority of normal cases. Here's an issue with more details if anyone would like to help with the issue/review the process.
There remains some "older" code to support older data while transitioning into this update, since I know there are some ongoing tournies that may want to re-analyze existing fights after this update. It will be removed later on.