Skip to content

update unmutedjingles 0.22#10579

Merged
riktenx merged 2 commits into
runelite:masterfrom
hootisman:unmutedjingles
Feb 24, 2026
Merged

update unmutedjingles 0.22#10579
riktenx merged 2 commits into
runelite:masterfrom
hootisman:unmutedjingles

Conversation

@hootisman
Copy link
Copy Markdown
Contributor

No description provided.

@runelite-github-app
Copy link
Copy Markdown

runelite-github-app Bot commented Feb 12, 2026

@runelite-github-app
Copy link
Copy Markdown

runelite-github-app Bot commented Feb 12, 2026

Feedback:

  • Use of javax.sound.sampled.AudioSystem.getLine is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.FloatControl.setValue is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.SourceDataLine.open is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.SourceDataLine.start is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.BooleanControl$Type is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.SourceDataLine.stop is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.Control$Type is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.Line$Info is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.BooleanControl.setValue is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.DataLine$Info.<init> is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.BooleanControl is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.AudioFormat is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.Line is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.FloatControl is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.DataLine$Info is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.SourceDataLine.getControl is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.SourceDataLine.flush is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.SourceDataLine.close is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.DataLine is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.SourceDataLine.getMicrosecondPosition is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.AudioFormat.<init> is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.FloatControl$Type.MASTER_GAIN is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.SourceDataLine.write is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.BooleanControl$Type.MUTE is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.FloatControl$Type is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.AudioSystem is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.SourceDataLine is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.SourceDataLine.drain is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.Control is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead

A new scan will be automatically performed on the next push to the PR branch.


Internal use only: Reviewer details Maintainer details

@hootisman
Copy link
Copy Markdown
Contributor Author

  • Rewritten mod using .wav files (increased file size)
  • Added Sailing and Combat Level jingles
  • Works with "Disable level-up interface" option

@riktenx
Copy link
Copy Markdown
Member

riktenx commented Feb 24, 2026

why the switch to mp3 exactly?

@riktenx riktenx merged commit a59a911 into runelite:master Feb 24, 2026
2 of 3 checks passed
@hootisman
Copy link
Copy Markdown
Contributor Author

why the switch to mp3 exactly?

I needed a way to stop the audio on a whim and couldn't find a way to do it with AudioPlayer. also I like the smaller file size of mp3 vs wav

@hootisman hootisman deleted the unmutedjingles branch February 24, 2026 00:57
Infinitay pushed a commit to Infinitay/plugin-hub that referenced this pull request Feb 26, 2026
* update unmutedjingles 0.22

* update unmutedjingles 0.22.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants