Skip to content

Revamped Lending Tracker to V2#10592

Merged
riktenx merged 22 commits into
runelite:masterfrom
Guess34:Guess34-patch-2
Mar 3, 2026
Merged

Revamped Lending Tracker to V2#10592
riktenx merged 22 commits into
runelite:masterfrom
Guess34:Guess34-patch-2

Conversation

@Guess34
Copy link
Copy Markdown
Contributor

@Guess34 Guess34 commented Feb 13, 2026

Lending Tracker
A RuneLite plugin for tracking items lent and borrowed between
players in Old School RuneScape.

Features:

Group system with role-based permissions (Owner, Co-Owner, Admin, Mod, Member)
Automated trade detection between group members
Peer-to-peer item marketplace
Return tracking with two-party confirmation
Borrow request system
Risk analysis and collateral tracking
Discord webhook notifications
Screenshot proof of trades
In-game safety overlays (wilderness, GE, drop warnings)
Online status tracking for group members
Full lending history with search
The plugin uses only standard RuneLite APIs and does not
automate gameplay or provide unfair advantages.

@runelite-github-app
Copy link
Copy Markdown

runelite-github-app Bot commented Feb 13, 2026

@runelite-github-app
Copy link
Copy Markdown

runelite-github-app Bot commented Feb 15, 2026

This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed.


Internal use only: Reviewer details Maintainer details

@Guess34
Copy link
Copy Markdown
Contributor Author

Guess34 commented Feb 16, 2026

Should be done sending commits with updates and fixes. Ready for review.

@riktenx
Copy link
Copy Markdown
Member

riktenx commented Feb 24, 2026

Is there a reason that this plugin is 28000 lines of code

image

I imagine there's some static data set I'm not seeing, but that aside it looks like you have a ton of files and code here. I don't really review anything much over 5k so in the interest of setting expectations it's unlikely that this will be reviewed within months or years, if ever, tbh. I am not aware of any reviewer that has the time or interest.

@riktenx riktenx added the waiting for author waiting for the pr author to make changes or respond to questions label Feb 24, 2026
@riktenx
Copy link
Copy Markdown
Member

riktenx commented Feb 24, 2026

ok yeah your panel alone is like 10k lines so see my last comment

@Guess34
Copy link
Copy Markdown
Contributor Author

Guess34 commented Feb 24, 2026

P2P marketplace system
Risk analysis & scoring
Collateral management
Peer review/ratings system
Discord webhook integration (with rate limiting, audit logging, token service)
Screenshot proof capture
Online status tracking
Notification bubble overlays
Item set bundles
Group sync system
Borrow request lifecycle
Daily reports

above is the core of the plugin as its got alot of features linked together. i understand its a massive undertaking for a review. ill see what i can cut it apart to make its much smaller and make it more of an mvp for yall and then start adding features back if that is more appropriate.

@runelite-github-app runelite-github-app Bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Feb 24, 2026
@riktenx riktenx added the waiting for author waiting for the pr author to make changes or respond to questions label Feb 24, 2026
@Guess34
Copy link
Copy Markdown
Contributor Author

Guess34 commented Feb 24, 2026

although i did notice i left the legacy panel in there but that only cuts ~11k lines of code. i do apologize for that error. ill comment back on how i can cut this down to a manageable push for you in a bit let me look into it if I'm able to go that route

@runelite-github-app runelite-github-app Bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Feb 24, 2026
@Felanbird Felanbird added the waiting for author waiting for the pr author to make changes or respond to questions label Feb 24, 2026
@runelite-github-app runelite-github-app Bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Feb 27, 2026
@riktenx
Copy link
Copy Markdown
Member

riktenx commented Mar 2, 2026

do not read/write files outside of .runelite, just make a subdirectory for your plugin in that folder and do everything in there

@riktenx riktenx added the waiting for author waiting for the pr author to make changes or respond to questions label Mar 2, 2026
@runelite-github-app runelite-github-app Bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Mar 2, 2026
@riktenx riktenx merged commit cc1cea9 into runelite:master Mar 3, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants