Skip to content

Update hallowed-sepulchre-helper with compliance adjustments #10599

Merged
LlemonDuck merged 3 commits into
runelite:masterfrom
zipon458:hallowed-sepulchre-helper
Mar 28, 2026
Merged

Update hallowed-sepulchre-helper with compliance adjustments #10599
LlemonDuck merged 3 commits into
runelite:masterfrom
zipon458:hallowed-sepulchre-helper

Conversation

@zipon458
Copy link
Copy Markdown
Contributor

This PR contains two parts combined into one submission:

  1. The previously queued update (route filtering/refactor/timer work)
  2. A first compliance pass based on my interpretation of Jagex feedback

I know this is a large PR. A big portion is route obstacle mapping/constants work from 1), and a lot of removing from 2) but if needed just lmk and I'll split further if that would help review.
1200 LOC are just from mapping every obstacle to routes in the RouteObstacles.java file like this:
addObstacle(new WorldPoint(2527, 5876, 2), EnumSet.of(SepulchreRoute.FLOOR_4_NORTH)); // WIZARD_STATUE

Changes in 1)
Route filtering, faster detection, and refactoring

  • Add route filtering to only show obstacles on current route
  • Faster route detection
  • Persist portal highlights when crossing loading lines
  • Various refactoring and cleanup
  • Timers hook to varbit timers for exact timers
  • Map all obstacles for all routes across all floors

Changes in 2)

  • Remove floor 4 wizard phase tracker
  • Remove countdown displays for portals, wizard statues, and knight statues
  • Change portal highlight from tile indication to 'less visible' graphics/object highlighting
  • Replace wizard fire tile indication with 'less visible' fire outline highlighting (no warning-state marking)
  • Change knight statue sword zone indication from zone tiles to statue highlighting

Note on interpretation / request for feedback

This is my first pass at adjusting the plugin to match the intended spirit of the feedback (especially around tile indication/where-to-stand style guidance).
This was at my sole interpretion, so if anything is still over the line or should be adjusted differently, please let me know and I will gladly adjust further.
I dont know if these reviews includes trying the plugin in-game, so if not heres a short video of the adjustments:

sepulchre_helper_changes.mp4

@runelite-github-app
Copy link
Copy Markdown

runelite-github-app Bot commented Feb 14, 2026

@runelite-github-app
Copy link
Copy Markdown

runelite-github-app Bot commented Feb 14, 2026

Internal use only: Reviewer details Maintainer details

@riktenx
Copy link
Copy Markdown
Member

riktenx commented Feb 25, 2026

Commenting in case another reviewer that doesn't have the prior context sees this. Jagex originally requested this plugin be removed but did not provide clear guidance as to what needs to removed to allow it to be re-added. Thus I skipped reviewing it for now and if you are a potential reviewer you should probably do the same.

@LlemonDuck
Copy link
Copy Markdown
Contributor

  • Change portal highlight from tile indication to 'less visible' graphics/object highlighting
  • Replace wizard fire tile indication with 'less visible' fire outline highlighting (no warning-state marking)
  • Change knight statue sword zone indication from zone tiles to statue highlighting

I've gotten info that you can undo these ones if you want, but keep out any advance warning stuff. You can highlight active hazards ~however you like but don't provide advance warning of future hazards.

@LlemonDuck LlemonDuck added the waiting for author waiting for the pr author to make changes or respond to questions label Mar 17, 2026
@zipon458
Copy link
Copy Markdown
Contributor Author

I've gotten info that you can undo these ones if you want, but keep out any advance warning stuff. You can highlight active hazards ~however you like but don't provide advance warning of future hazards.

Hi, thank you for the follow-up, its greatly appreciated!
Will fix accordingly

@runelite-github-app runelite-github-app Bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Mar 17, 2026
@Felanbird Felanbird added the waiting for author waiting for the pr author to make changes or respond to questions label Mar 17, 2026
pluginhub compliance runelite#2 pass

remove floor 4 phase tracker
remove countdown from portals, wizards and knight statues 
remove knight statue zone highlight (both warning and hazard) 
remove warning highlight for wizard statues
@runelite-github-app runelite-github-app Bot added size-l and removed waiting for author waiting for the pr author to make changes or respond to questions size-xl labels Mar 17, 2026
@zipon458
Copy link
Copy Markdown
Contributor Author

zipon458 commented Mar 17, 2026

The part at in my original comment about 1) is still true.
2) has been changed to:
undo #1 pass changes
remove floor 4 phase tracker
remove countdown from portals, wizards and knight statues
remove knight statue zone highlight (both warning and hazard)
remove warning highlight for wizard statues

Let me know if you have any further comments

Heres an updated video:

unknown_2026.03.17-16.17.mp4

@LlemonDuck LlemonDuck closed this Mar 24, 2026
@LlemonDuck LlemonDuck reopened this Mar 24, 2026
@LlemonDuck LlemonDuck closed this Mar 28, 2026
@LlemonDuck LlemonDuck reopened this Mar 28, 2026
Comment thread plugins/hallowed-sepulchre-helper Outdated
@LlemonDuck LlemonDuck merged commit 7873a0a into runelite:master Mar 28, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants