Update tick-fixer-for-mac to v2.0.0

[jonathangarelick]

• Uses UDP instead of ICMP to keep wifi radio awake
• Adds optional tick tracking UI (off by default)
• Adds more configuration options

[runelite-github-app]

tick-fixer-for-mac: 02bbfc056014b4fc59f9cb159179d84f6be395a1..9768bbb8939f693c5f91ce6a712f67314508bac0

[runelite-github-app]

This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed.

---

Internal use only: Reviewer details Maintainer details

[pajlada]

You've changed your ipAddress config key to targetHost - It would probably be a good idea to either revert the key name change so users don't lose their config, or perform an automatic migration on plugin startup. Let me know if this doesn't make sense with the changes you've made from ping -> udp.

When a user changes the target host config and it fails to resolve, the user is not informed and the the service keeps pinging the old host. It's probably a good idea to inform the user through a chat message, or pausing/disabling the keepalive thread or something.

I don't like your waitFor endlessly blocking in WifiKeepaliveThread's detectDefaultGateway, please add a reasonable timeout (probably in the hundreds of milliseconds?)

In WifiKeepaliveThread's shutdown, don't await termination in the scheduler.

Thanks for making the overlay off by default

[jonathangarelick]

@pajlada Updated, thanks.

[pajlada]

Could you move your resolving logic to WifiKeepaliveThread's executor? Essentially what I'd like is for there to be no blocking logic on RuneLite's client or RuneLite threads.
Thanks!

[jonathangarelick]

Updated, thanks.

[pajlada]

Thanks for your patience