Skip to content

update hiscores-tracker#10693

Merged
riktenx merged 2 commits into
runelite:masterfrom
RobertoChavez2433:update-hiscores-tracker-v2
Mar 8, 2026
Merged

update hiscores-tracker#10693
riktenx merged 2 commits into
runelite:masterfrom
RobertoChavez2433:update-hiscores-tracker-v2

Conversation

@RobertoChavez2433
Copy link
Copy Markdown
Contributor

Updated hiscores-tracker with performance and feature improvements:

  • Auto-daily fetch — captures snapshots on login and hourly so users don't have to do it manually
  • Performance: debounced stat events, batched file writes, duplicate snapshot detection
  • Thread safety: snapshot building moved off the game thread, async data initialization
  • UI: in-place row updates instead of full panel rebuilds, inline status labels
  • API retry with backoff, tiered snapshot compaction to manage storage
  • Various code review fixes (generation guards, EDT safety, gains accuracy)

@runelite-github-app
Copy link
Copy Markdown

runelite-github-app Bot commented Feb 22, 2026

@runelite-github-app
Copy link
Copy Markdown

runelite-github-app Bot commented Feb 22, 2026

This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed.


Internal use only: Reviewer details Maintainer details

@riktenx
Copy link
Copy Markdown
Member

riktenx commented Feb 25, 2026

  • don't ever block on shutDown, just shutdownNow your executors and be done with it
    • also don't use thread interrupt in the way you're doing. it should literally just be myExecutor.shutdownNow
  • don't use thread.sleep
  • you need to explicitly cancel this in addition to shutting down the executor

@riktenx riktenx added the waiting for author waiting for the pr author to make changes or respond to questions label Feb 25, 2026
Address maintainer feedback on PR runelite#10693.
@RobertoChavez2433
Copy link
Copy Markdown
Contributor Author

RobertoChavez2433 commented Mar 5, 2026

Thank you for the comments. Addressed all of your items I believe. Added shutdownNow and explicitly cancelled before shutdown. Let me know if I missed anything. Thanks again.

@runelite-github-app runelite-github-app Bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Mar 5, 2026
@riktenx riktenx merged commit 5ad6164 into runelite:master Mar 8, 2026
2 of 3 checks passed
CCatRS pushed a commit to CCatRS/plugin-hub that referenced this pull request Apr 2, 2026
* update hiscores-tracker to v2

* Update hiscores-tracker commit hash

Address maintainer feedback on PR runelite#10693.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants