Skip to content

Merge Atlas' ChanceMan v3 to Choicer#10726

Merged
riktenx merged 2 commits into
runelite:masterfrom
Attoz:choicer-merge-atlas-changes
Feb 25, 2026
Merged

Merge Atlas' ChanceMan v3 to Choicer#10726
riktenx merged 2 commits into
runelite:masterfrom
Attoz:choicer-merge-atlas-changes

Conversation

@Attoz
Copy link
Copy Markdown
Contributor

@Attoz Attoz commented Feb 24, 2026

Merged Atlas' big updates from ChanceMan v3 to Choicer

ChunkyAtlas/chance-man@a5628ef

"refactor(choicer): rework rolled vs obtained item model, correct roll causality and chat messaging, migrate unlocked → obtained naming, and replace sidebar item toggles with explicit list-based filtering, bump to v1.2.0

  • remove extra down arrow on "Filter"

fix(panel): move item name/icon resolution onto client thread, fix EDT races, add filter tooltips

  • update README

fix(domain,ui,filters): correct obtained vs rolled semantics across GE, drops, and panel

  • Correct domain meaning: Rolled = unlocked/usable, Obtained = actually acquired
  • Fix GE search filtering to gate by Rolled (optionally Obtained)
  • Fix roll logic so only Rolled items are treated as unlocked
  • Update panel:
    • Default view is Rolled items
    • Add Rolled, not Obtained view
    • Reorder list priority (Rolled → Obtained)
    • Fix Usable logic to require both Rolled and Obtained
  • Fix drop viewer to track Obtained items instead of Rolled
  • Update progress bar, opacity, and hide-toggle to use Obtained
  • Migrate legacy unlocked/rolled naming safely
  • Add safety guards (empty sets, divide-by-zero)
  • Update README

refactor(choicer): unify rolled vs obtained model, fix progression semantics, update UI, and bump to v3.0.0

  • Rework core item state model:
    • Rolled = unlocked / allowed
    • Obtained = actually acquired in-game
    • Item is usable only when both Rolled and Obtained
  • Correct roll causality and chat messaging to reflect obtain → roll relationship
  • Migrate legacy unlocked/rolled naming safely to obtained/rolled
  • Fix GE filtering and restrictions to gate by Rolled (optionally also Obtained)
  • Ensure only Rolled items are treated as unlocked across domain logic

UI & panel updates:

  • Replace sidebar toggles with explicit list-based filtering
  • Default panel view to Rolled items
  • Add “Rolled, not Obtained” view
  • Fix Usable logic to require both Rolled and Obtained
  • Reorder list priority (Rolled → Obtained)
  • Add filter tooltips and remove extra dropdown arrow
  • Move item name/icon resolution onto client thread and fix EDT races

Drops & visuals:

  • Update drop viewer to track Obtained items (not Rolled)
  • Fix progress bar, icon opacity, and hide-toggle to use Obtained state
  • Add safety guards (empty sets, divide-by-zero)

Docs:

  • Update README to reflect corrected semantics and UI behavior

Version:

  • Bump plugin version to v1.2.0

fix(migration): safely handle legacy file renaming for v3 migration

  • Rename legacy "choicer_rolled.json" file during v3 migration
  • Archive old legacy file and ensure smooth transition to new file names ("choicer_obtained.json" and "choicer_rolled.json")
  • Prevent overwriting issues for new players and ensure proper file creation
  • Add safe migration checks for existing data and ensure new data structure works as expected"

@runelite-github-app
Copy link
Copy Markdown

@runelite-github-app
Copy link
Copy Markdown

This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed.


Internal use only: Reviewer details Maintainer details

@riktenx riktenx merged commit fbf76af into runelite:master Feb 25, 2026
2 of 3 checks passed
Infinitay pushed a commit to Infinitay/plugin-hub that referenced this pull request Feb 26, 2026
* merge Atlas' ChanceMan 3.0.0 changes to Choicer

* bump version to v1.2.0
@Attoz Attoz deleted the choicer-merge-atlas-changes branch March 1, 2026 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants